Skip to content

[tests-only][full-ci] adding test for trying to create auth app-token for other user without impersonation env#10983

Merged
nirajacharya2 merged 1 commit intomasterfrom
create-auth-app-no-imp-env
Feb 18, 2025
Merged

[tests-only][full-ci] adding test for trying to create auth app-token for other user without impersonation env#10983
nirajacharya2 merged 1 commit intomasterfrom
create-auth-app-no-imp-env

Conversation

@nirajacharya2
Copy link
Copy Markdown
Contributor

@nirajacharya2 nirajacharya2 commented Feb 10, 2025

Description

This PR adds test for trying to create auth-app token for other user without impersonation env

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Copy Markdown
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/acceptance/features/apiAuthApp/token.feature Outdated
Comment thread tests/acceptance/features/apiAuthApp/token.feature Outdated
@nirajacharya2 nirajacharya2 force-pushed the create-auth-app-no-imp-env branch from 61cff22 to 21b5410 Compare February 12, 2025 03:28
Comment thread tests/acceptance/features/apiAuthApp/token.feature Outdated
@nirajacharya2 nirajacharya2 force-pushed the create-auth-app-no-imp-env branch from 21b5410 to f591a4f Compare February 12, 2025 07:12
Comment thread tests/acceptance/bootstrap/AuthAppContext.php Outdated
Copy link
Copy Markdown
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

step refactored to take dynamic user name but using admin credentials why?

$this->featureContext->getAdminUsername(),
			$this->featureContext->getAdminPassword(),

@nirajacharya2 nirajacharya2 force-pushed the create-auth-app-no-imp-env branch 2 times, most recently from b0c836b to c15b373 Compare February 13, 2025 03:35
Comment thread tests/acceptance/features/apiAuthApp/token.feature
Comment thread tests/acceptance/bootstrap/AuthAppContext.php Outdated
Comment thread tests/acceptance/features/apiAuthApp/token.feature Outdated
@nirajacharya2 nirajacharya2 force-pushed the create-auth-app-no-imp-env branch 2 times, most recently from e481f23 to b883700 Compare February 14, 2025 07:10
@nirajacharya2 nirajacharya2 force-pushed the create-auth-app-no-imp-env branch 2 times, most recently from 53eaff1 to fd485c7 Compare February 17, 2025 04:01
@nirajacharya2 nirajacharya2 force-pushed the create-auth-app-no-imp-env branch from fd485c7 to b5e5d94 Compare February 18, 2025 03:21
@sonarqubecloud
Copy link
Copy Markdown

@nirajacharya2 nirajacharya2 merged commit df4a46e into master Feb 18, 2025
ownclouders pushed a commit that referenced this pull request Feb 18, 2025
[tests-only][full-ci] adding test for trying to create auth app-token for other user without impersonation env
@nirajacharya2 nirajacharya2 deleted the create-auth-app-no-imp-env branch February 26, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants