Skip to content

chore: fix SASS round function deprecation #12338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

chore: fix SASS round function deprecation #12338

merged 1 commit into from
Mar 24, 2025

Conversation

LukasHirt
Copy link
Collaborator

Description

Replace SASS round function with the correct math.round to keep using the SASS function.

Related Issue

Motivation and Context

No deprecation warnings and consistent functions usage.

How Has This Been Tested?

  • test environment: 🤖
  • test case 1: Run pnpm build

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt
chore: fix SASS round function deprecation
6ba09e7 
Replace it with the correct math.round to keep using the SASS function.
@LukasHirt LukasHirt requested a review from mzner March 20, 2025 10:12
@LukasHirt LukasHirt self-assigned this Mar 20, 2025
@update-docs Update Docs

This comment was marked as off-topic.

Sign in to view
@LukasHirt LukasHirt enabled auto-merge March 20, 2025 10:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LukasHirt LukasHirt requested review from mzner and removed request for mzner March 24, 2025 08:36
@LukasHirt LukasHirt merged commit 9a97039 into master Mar 24, 2025
4 checks passed
@LukasHirt LukasHirt deleted the chore/sass-round-deprecation branch March 24, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzner mzner mzner approved these changes

Assignees

@LukasHirt LukasHirt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sass deprecation warnings
2 participants
@LukasHirt @mzner