Skip to content

Fix nightly and WASI example build failure #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oxalica merged 2 commits into from
Sep 15, 2025
Merged

Fix nightly and WASI example build failure #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4232f52
mk-component-set: fix nightly build failure on non-empty `/etc`.
oxalica Sep 15, 2025
3587bb8
example: fix WASI example CI failure
oxalica Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/cross-wasi/shell.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
mkShellNoCC {
nativeBuildInputs = [ rust-bin.stable.latest.minimal ];

depsBuildBuild = [ wasmtime ];
depsBuildBuild = [ wasmtime.out ];

# This is optional for wasm32-like targets, since rustc will automatically use
# the bundled `lld` for linking.
Expand Down
3 changes: 2 additions & 1 deletion lib/mk-component-set.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ let
}
if [[ -e "$out/etc" ]]; then
handleEtc "$out/etc/bash_completion.d" "$out/share/bash-completion/completions"
rmdir $out/etc || { echo "Installer tries to install to /etc: $(ls $out/etc)"; exit 1; }
# Remove if empty. Skip if produced `/etc/target-spec-json-schema.json`.
rmdir --ignore-fail-on-non-empty $out/etc
fi
'';

Expand Down