Skip to content

refactor: extract definition_start helper for description-aware spans#54

Merged
Boshen merged 1 commit into
mainfrom
refactor-description-start
Jul 12, 2026
Merged

refactor: extract definition_start helper for description-aware spans#54
Boshen merged 1 commit into
mainfrom
refactor-description-start

Conversation

@Boshen

@Boshen Boshen commented Jul 12, 2026

Copy link
Copy Markdown
Member

Ten definition parsers repeated the same two-line expression to pick a span start: the description's start if one was parsed, otherwise the current token. Name it once as Parser::definition_start.

No behavior change. Validated with cargo fmt --check, cargo clippy --all-targets, and cargo test.

@codspeed-hq

codspeed-hq Bot commented Jul 12, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 5 skipped benchmarks1


Comparing refactor-description-start (07f0b3f) with main (822314b)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen Boshen merged commit 8ee87f5 into main Jul 12, 2026
9 checks passed
@Boshen Boshen deleted the refactor-description-start branch July 12, 2026 10:14
@oxc-guard oxc-guard Bot mentioned this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant