Remove support for VectorOfVariables #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the tip in https://jump.dev/MathOptInterface.jl/stable/tutorials/implementing/#Define-supports_constraint, a solver shouldn't support constraint types that are reformulated in the MOI wrapper into another but only the ones that are natively supported.
Indeed, it allows simplifying the MOI wrapper without altering what is supporting through JuMP since the bridge layer will do the necessary translation.
Moreover, making the
supports_constraintbetter reflect what is natively supported help the bridge layer do better decisions when bridging.