Add allow_ddm_traffic to PortConfig - #11091
Conversation
6cc81ce to
238e6b3
Compare
50dd23a to
e71b23d
Compare
238e6b3 to
8ba5f1c
Compare
e71b23d to
5cea605
Compare
8ba5f1c to
8f9463f
Compare
4ffb3b1 to
4109307
Compare
| /// future, older blobs can still be deserialized correctly. | ||
| fn current_config_example() -> (&'static str, EarlyNetworkConfigEnvelope) { | ||
| // NOTE: the description must not contain commas or newlines. | ||
| let description = "2026-04-28 pre-r20"; |
There was a problem hiding this comment.
Need to change the description here to get a new line in the expectorate output to keep this version in the list of regression tests. (I'm not 100% sure we still need this test with all the bootstore rework, but I haven't gone through to confirm it's really okay to remove.)
| management_addrs: c.management_ip.map(|ip| vec![ip]), | ||
| }), | ||
| tx_eq, | ||
| allow_ddm_traffic: false, |
There was a problem hiding this comment.
This isn't necessarily a blocker for this PR, but might impact testing - IIUC, as written, RSS will write any allow_ddm_traffic: true values from the RSS config into the bootstore when it does it initial population of it. But once Nexus starts running, the sync_switch_configuration bg task will send down new bootstore contents with this false set on every port, so you may lose the ddm traffic as soon as Nexus gets started running bg tasks.
2 participants
This is necessary to both enable front ports for DDM and disable front ports as uplink ports in dpd. Both are necessary for multirack.
It's important to note that this is a temporary fix to get multirack moving. We expect to overhaul the structure of
RackNetworkConfigandPortConfigsoon. BgpPeer info should likely live outside the port itself and ports should only contain link-level information.