Add database layer for assigning an IP Pool to a service - #11109
Merged
bnaecker merged 3 commits intoAug 21, 2026
Conversation
bnaecker
marked this pull request as draft
August 19, 2026 03:04
bnaecker
force-pushed
the
ben/add-external-ip-pool-service-association-table
branch
from
August 19, 2026 20:26
ddf215e to
08178ba
Compare
- Add an enum for external networking services. - Add a join table for associating `ip_pool` records with specific services. - Add datastore methods for assigning / unassigning, with a bunch of tests. - The join table is empty and the datastore methods aren't consumed. This is all plumbing work, to support the planned Nexus API for operators and letting Reconfigurator read the pools it should use to plan external addresses for its zones.
bnaecker
force-pushed
the
ben/add-external-ip-pool-service-association-table
branch
from
August 19, 2026 20:29
08178ba to
3f01ca3
Compare
bnaecker
marked this pull request as ready for review
August 19, 2026 20:29
jgallagher
reviewed
Aug 20, 2026
- use matches_sentinel in more places - typed IP Pool kind - ensure we can't reassign a pool to silos if it's assigned for a specific service like Nexus, and add regression test - comment cleanup
jgallagher
approved these changes
Aug 21, 2026
bnaecker
enabled auto-merge (squash)
August 21, 2026 16:05
bnaecker
deleted the
ben/add-external-ip-pool-service-association-table
branch
August 21, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ip_poolrecords with specific services.