-
Notifications
You must be signed in to change notification settings - Fork 14
test(fuzz): differential fuzzing against upstream Baileys #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 46 commits
27f449f
879a03f
78f1660
71af124
4623ea0
4edf11a
6853d65
81998b7
919a4b8
6996078
5b5347f
208947a
86a9e02
a0c91bb
2cedd89
be6c893
efe09cd
cedac01
c8f09c5
f776a00
627378e
a204a57
b77946a
8956734
f4daa5a
229e634
9ef1534
5d40709
d25c199
918f5a6
20b5181
89bc565
855cf1a
6e83224
0d75d71
339c7c7
8b00212
03a58f9
cc26669
da42e1c
d8ea5e1
fd6ab9e
0f92629
7e9f5ab
f07b816
bebf7a5
4418fd1
5e60d67
48b701c
94cc655
62db42c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,261 @@ | ||
| name: Nightly Fuzz | ||
|
|
||
| # Two modes, on purpose. | ||
| # | ||
| # Every pull request already runs the fuzz suite through `npm test`, with a fixed | ||
| # seed and small per-target budgets. That run is deterministic: it cannot fail | ||
| # because of an unlucky draw, which is the only way a fuzz suite survives contact | ||
| # with a CI system people have to trust. | ||
| # | ||
| # This job is where the searching happens. It varies the seed per run, raises the | ||
| # budgets, and enforces the parts of the known-divergence registry that would be | ||
| # hostile on a pull request — entries past their review date, and entries that no | ||
| # longer excuse anything. | ||
|
|
||
| on: | ||
| schedule: | ||
| # 03:17 UTC, off the hour so it does not queue behind everything else. | ||
| - cron: '17 3 * * *' | ||
| workflow_dispatch: | ||
| inputs: | ||
| seed: | ||
| description: 'Fuzz seed (defaults to the run id)' | ||
| required: false | ||
| type: string | ||
| mode: | ||
| description: 'smoke or deep' | ||
| required: false | ||
| default: 'deep' | ||
| # A choice, not free text: the runner rejects anything else outright, and | ||
| # a rejected dispatch is better than one that silently runs a smoke pass. | ||
| type: choice | ||
| options: | ||
| - deep | ||
| - smoke | ||
|
|
||
| # One fuzz run at a time in the *repository*, not per ref. The tracking issue is | ||
| # repository-wide, so two runs on different refs — a nightly and a manual | ||
| # dispatch on a branch — would each look it up, each find nothing, and each | ||
| # create one. Every later run then comments on and closes only the lowest | ||
| # number, leaving the duplicate open forever holding a stale report. Queued | ||
| # rather than cancelled: the in-flight run's result is the one worth keeping. | ||
| concurrency: | ||
| group: fuzz | ||
| cancel-in-progress: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
| issues: write | ||
|
|
||
| jobs: | ||
| fuzz: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 45 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
jlucaso1 marked this conversation as resolved.
|
||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '24' | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run the fuzz suite | ||
| id: fuzz | ||
| env: | ||
| # A fresh seed per run is the point: the fixed-seed smoke run on every | ||
| # PR has already searched its own corner exhaustively. | ||
| FUZZ_SEED: ${{ inputs.seed || github.run_id }} | ||
| FUZZ_MODE: ${{ inputs.mode || 'deep' }} | ||
| FUZZ_TIME_BUDGET_MS: '180000' | ||
| FUZZ_REPORT_DIR: fuzz-reports | ||
| FUZZ_STRICT_ALLOWLIST: '1' | ||
| # --expose-gc turns on the WASM handle-leak probe, which skips without it. | ||
| # --test-timeout bounds a decoder that stops returning: the runner's own | ||
| # slowMs is measured after the check completes, so it cannot see an input | ||
| # that never completes. The parent process owns this timer, so it fires | ||
| # even when the child's event loop is blocked by a synchronous WASM loop. | ||
| run: node --expose-gc --test --test-timeout=1800000 "./src/__fuzz__/**/*.test.ts" | ||
| continue-on-error: true | ||
|
jlucaso1 marked this conversation as resolved.
cubic-dev-ai[bot] marked this conversation as resolved.
|
||
|
|
||
| - name: Summarise | ||
| id: report | ||
| if: always() | ||
| run: | | ||
| { | ||
| node scripts/fuzz/report.ts fuzz-reports --markdown --fail-on-stale \ | ||
| ${{ steps.fuzz.outcome == 'success' && ' ' || '--run-failed' }} | ||
|
Comment on lines
+91
to
+92
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a manual dispatch selects Useful? React with 👍 / 👎. |
||
| } > fuzz-summary.md 2>&1 && echo "clean=true" >> "$GITHUB_OUTPUT" || echo "clean=false" >> "$GITHUB_OUTPUT" | ||
| cat fuzz-summary.md >> "$GITHUB_STEP_SUMMARY" | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| - name: Upload reports | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: fuzz-reports-${{ github.run_id }} | ||
| path: | | ||
| fuzz-reports/ | ||
| fuzz-summary.md | ||
| retention-days: 30 | ||
|
|
||
| # The fuzz outcome is part of the condition, not just the report: a run can | ||
| # fail on something the report has no findings for — a harness crash, a | ||
| # suite-level assertion — and an issue is exactly what those need too. | ||
| # | ||
| # Runs on every outcome, not only failures. A clean run has something to | ||
| # say too: without it the tracking issue stayed open forever holding a | ||
| # report the nightly had since disproved, which is the fastest way to | ||
| # teach people to ignore it. | ||
| - name: Update the tracking issue | ||
| if: always() | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const fs = require('node:fs') | ||
| const summary = fs.readFileSync('fuzz-summary.md', 'utf8') | ||
| // The seed is a free-form workflow input, so the reproduction command | ||
| // has to quote it or it is not the command that ran: `nightly run` | ||
| // would make the shell treat `run` as the program, and a `;` would | ||
| // append a second command to whatever the reader pastes. Same rule as | ||
| // the runner's own replay hint. | ||
| const shellQuote = value => | ||
| /^[\w.:@/+=-]+$/.test(value) ? value : `'${String(value).replaceAll("'", String.raw`'\''`)}'` | ||
| // The same condition the step used to be gated on, now a value: the | ||
| // report found nothing *and* the run itself did not fail. | ||
| const clean = ${{ steps.report.outputs.clean == 'true' && steps.fuzz.outcome == 'success' }} | ||
| const seed = process.env.FUZZ_SEED | ||
| const mode = process.env.FUZZ_MODE | ||
| const budget = process.env.FUZZ_TIME_BUDGET_MS | ||
| // Stable across runs, so the issue this job owns is identifiable by | ||
| // something other than a label anyone can apply. The seed moved into | ||
| // the body: it changes nightly, and a title that changes cannot be a key. | ||
| const title = 'Nightly fuzz: open findings' | ||
| const marker = '<!-- nightly-fuzz-tracking-issue -->' | ||
|
|
||
| // One open issue per topic, updated rather than duplicated: a fuzzer | ||
| // that opens a fresh issue every night trains people to close them | ||
| // unread. | ||
| // | ||
| // Matched on the marker alone. `listForRepo` returns pull requests as | ||
| // well as issues, and the generic `fuzz` label is one anybody can put on | ||
| // anything — so the label by itself would let the nightly report land in | ||
| // an unrelated thread, or on a PR, and the API's default ordering makes | ||
| // which one unstable as more labelled items are opened. | ||
| // | ||
| // And the label cannot be part of the *query* either, only of the | ||
| // answer. A label is editable by anyone with write access: strip `fuzz` | ||
| // from the open tracking issue and a label-scoped search stops returning | ||
| // it before the marker is ever consulted, so the next failing night files | ||
| // a duplicate and no clean night can ever find and close the original. | ||
| // The marker lives in the body, which is the one part of the issue this | ||
| // job writes and nothing routine edits. It still *applies* the label on | ||
| // creation, for people who browse that way — it just never trusts it. | ||
| // | ||
| // The cost is listing open issues rather than a label slice, which is | ||
| // why it paginates. The lowest number wins, so the choice does not depend | ||
| // on page order either. | ||
| const open = await github.paginate(github.rest.issues.listForRepo, { | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| state: 'open', | ||
| per_page: 100 | ||
| }) | ||
| const owned = open | ||
| .filter(item => !item.pull_request && (item.body ?? '').includes(marker)) | ||
| .sort((left, right) => left.number - right.number) | ||
|
Comment on lines
+184
to
+193
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Any repository user can open an issue whose body contains this publicly visible marker, but the lookup treats the marker alone as proof that the workflow owns the issue. If that issue has the lowest number, a failing nightly posts its report there instead of creating or updating the real tracker; a clean nightly will comment on and close every such user-authored issue. Restrict matches to issues created by the workflow's bot identity (and preferably the expected title) before updating or closing them. Useful? React with 👍 / 👎. |
||
|
|
||
| const body = [ | ||
| marker, | ||
| `Seed: \`${seed}\` · mode \`${mode}\``, | ||
| '', | ||
| summary, | ||
| '', | ||
| `Run: ${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`, | ||
| // The run's own flags, or the reproduction can pass where the run | ||
| // failed: without --expose-gc the leak probe skips, without | ||
| // FUZZ_STRICT_ALLOWLIST an expired entry is a warning rather than a | ||
| // failure, and the budget decides how many inputs each target gets | ||
| // through before it truncates. The mode is read back rather than | ||
| // hard-coded to `deep`, because a manual dispatch can run `smoke` | ||
| // and `npm run fuzz:deep` would then reproduce a different run. | ||
| `Reproduce locally: \`FUZZ_SEED=${shellQuote(seed)} FUZZ_MODE=${mode} FUZZ_TIME_BUDGET_MS=${budget} FUZZ_STRICT_ALLOWLIST=1 node --expose-gc --test --test-timeout=1800000 "./src/__fuzz__/**/*.test.ts"\``, | ||
| '', | ||
| '---', | ||
| '_Generated by [Claude Code](https://claude.ai/code)_' | ||
| ].join('\n') | ||
|
|
||
| // A clean run closes the issue rather than opening one. Commented | ||
| // first, so the thread records *why* it closed and against which | ||
| // seed — a bare close leaves whoever reopens it guessing. | ||
| // Every owned issue, not just the lowest. The concurrency group is | ||
| // repository-wide now so two runs cannot race into duplicates, but one | ||
| // may already exist from before that, or from a hand-filed issue | ||
| // carrying the marker — and closing only `owned[0]` would leave it open | ||
| // forever holding a report the nightly has disproved. | ||
| if (clean) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a nightly opens this issue for a seed-specific finding, a later clean run—especially a manual Useful? React with 👍 / 👎. |
||
| for (const issue of owned) { | ||
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: issue.number, | ||
| body: [ | ||
| marker, | ||
| `The nightly is clean on seed \`${seed}\` (mode \`${mode}\`), so this is closed.`, | ||
| '', | ||
| `Run: ${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`, | ||
| '', | ||
| 'It reopens by itself: the next run with findings files against this same marker, or creates a fresh issue if this one is closed.', | ||
| '', | ||
| '---', | ||
| '_Generated by [Claude Code](https://claude.ai/code)_' | ||
| ].join('\n') | ||
| }) | ||
| await github.rest.issues.update({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: issue.number, | ||
| state: 'closed', | ||
| state_reason: 'completed' | ||
| }) | ||
| } | ||
| return | ||
| } | ||
|
|
||
| if (owned.length > 0) { | ||
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: owned[0].number, | ||
| body | ||
| }) | ||
| } else { | ||
| await github.rest.issues.create({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| title, | ||
| body, | ||
| labels: ['fuzz'] | ||
| }) | ||
| } | ||
| env: | ||
| FUZZ_SEED: ${{ inputs.seed || github.run_id }} | ||
| # Mirrored from the run step, so the reproduction command names the mode | ||
| # and budget the findings were actually produced under. | ||
| FUZZ_MODE: ${{ inputs.mode || 'deep' }} | ||
| FUZZ_TIME_BUDGET_MS: '180000' | ||
|
|
||
| # The fuzz and summarise steps deliberately do not fail on the spot, so the | ||
| # artifacts get uploaded and the issue gets filed first. Without a final gate | ||
| # the job would then finish green holding findings, which is the one outcome | ||
| # that would make the whole nightly pointless. | ||
| - name: Fail the job when the run was not clean | ||
| if: always() && (steps.fuzz.outcome != 'success' || steps.report.outputs.clean != 'true') | ||
| run: | | ||
| echo "fuzz outcome: ${{ steps.fuzz.outcome }}" | ||
| echo "report clean: ${{ steps.report.outputs.clean }}" | ||
| exit 1 | ||
Uh oh!
There was an error while loading. Please reload this page.