Skip to content

Move the library and gpui to their current heads - #15

Merged
jlucaso1 merged 1 commit into
mainfrom
claude/bump-whatsapp-rust-gpui-pro8h4
Aug 27, 2026
Merged

Move the library and gpui to their current heads#15
jlucaso1 merged 1 commit into
mainfrom
claude/bump-whatsapp-rust-gpui-pro8h4

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

All three git dependencies are branch-tracked and pinned only by the committed lockfile, so a bump is a lockfile change and nothing else. Every crate from one source moves to the same commit, which is the property the manifest's comment exists to protect.

What moved

whatsapp-rust and its satellitesed543cbd6a0455, a single commit: oxidezap/whatsapp-rust#1352, which dispatches a resent message once. A retransmitted stanza used to reach the event stream twice, so the chat store wrote the row twice; nothing here changes to receive the fix.

gpui and the gpui_platform familyf1d27d51e2e422. The gpui-facing changes in that range are text-input configuration and a web implementation, pending input cleared when a window is blurred, headless render-to-image on Windows, a wrapping rule that no longer starts a line with closing punctuation, and stack growth (stacker) becoming opt-in.

gpui-component7885c416d07863. This is why the two move together rather than in separate PRs: the component library tracks zed HEAD, and the range carries its own "Update GPUI and fix API changes". Holding one back would put two gpui revisions in the tree, which the same-source rule in crates/gui/Cargo.toml exists to prevent. It also brings a scrollbar repaint fix after a click on the track, max_lines on text_view, markdown tables styled from the theme's table_* tokens, and a virtual list's stale cx in gpui-shell.

Fallout in the lock

Eight transitive crates left the graph — stacker and psm behind gpui's now opt-in stack growth, plus the second rustix/linux-raw-sys pair, ar_archive_writer, object, home and winsafe — and strum moved to 0.28, which to 8. Nothing in the workspace names any of them; they were all pulled in through zed.

No source file changes: no API this client calls moved in any of the three ranges.

Verification

Cargo.lock is the whole diff, so the check that matters is that the tree still builds and passes against the new heads — left to CI here, which runs cargo fmt, cargo clippy --workspace --all-targets -- -D warnings and cargo test --workspace on all three platforms. A local full build on this machine is slower than the CI matrix by a wide margin, and it would be checking the same thing.


Generated by Claude Code


Summary by cubic

Moves all branch-tracked git dependencies to their current heads; the entire diff is Cargo.lock and no workspace source changes are needed. whatsapp-rust now dispatches a resent message once instead of twice, which previously caused the chat store to write the row twice.

Dependencies

  • gpui and gpui-component move together to keep a single gpui revision in the tree; the range fixes input handling and makes stack growth via stacker opt-in.
  • The lock drops transitives no workspace crate names: stacker, psm, a duplicate rustix/linux-raw-sys pair, home, and winsafe.
  • strum moved to 0.28 and which to 8.

Written for commit d30c3c3. Summary will update on new commits.

Review in cubic

All three git sources are branch-tracked and pinned only by this lockfile,
so a bump is a lockfile change and nothing else:

- whatsapp-rust and its satellites, ed543cb -> d6a0455, one commit: a resent
  message is dispatched once instead of twice.
- gpui and the gpui_platform family, f1d27d5 -> 1e2e422.
- gpui-component, 7885c41 -> 6d07863, which carries its own "Update GPUI and
  fix API changes" — the reason both move in the same commit rather than
  separately: the component library tracks zed HEAD, and one gpui in the tree
  is what keeps them the same crate.

Cargo dropped eight transitive crates in the process (stacker and psm behind
gpui's now opt-in stack growth, the second rustix and linux-raw-sys, ar_archive_writer,
object, home, winsafe) and moved strum to 0.28 and which to 8.
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 106d01e7-6e8c-4452-82e9-c3b648106b62

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jlucaso1
jlucaso1 merged commit 7798a22 into main Aug 27, 2026
6 checks passed
@jlucaso1
jlucaso1 deleted the claude/bump-whatsapp-rust-gpui-pro8h4 branch August 27, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant