Move the library and gpui to their current heads - #15
Conversation
All three git sources are branch-tracked and pinned only by this lockfile, so a bump is a lockfile change and nothing else: - whatsapp-rust and its satellites, ed543cb -> d6a0455, one commit: a resent message is dispatched once instead of twice. - gpui and the gpui_platform family, f1d27d5 -> 1e2e422. - gpui-component, 7885c41 -> 6d07863, which carries its own "Update GPUI and fix API changes" — the reason both move in the same commit rather than separately: the component library tracks zed HEAD, and one gpui in the tree is what keeps them the same crate. Cargo dropped eight transitive crates in the process (stacker and psm behind gpui's now opt-in stack growth, the second rustix and linux-raw-sys, ar_archive_writer, object, home, winsafe) and moved strum to 0.28 and which to 8.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All three git dependencies are branch-tracked and pinned only by the committed lockfile, so a bump is a lockfile change and nothing else. Every crate from one source moves to the same commit, which is the property the manifest's comment exists to protect.
What moved
whatsapp-rust and its satellites —
ed543cb→d6a0455, a single commit: oxidezap/whatsapp-rust#1352, which dispatches a resent message once. A retransmitted stanza used to reach the event stream twice, so the chat store wrote the row twice; nothing here changes to receive the fix.gpui and the
gpui_platformfamily —f1d27d5→1e2e422. The gpui-facing changes in that range are text-input configuration and a web implementation, pending input cleared when a window is blurred, headless render-to-image on Windows, a wrapping rule that no longer starts a line with closing punctuation, and stack growth (stacker) becoming opt-in.gpui-component —
7885c41→6d07863. This is why the two move together rather than in separate PRs: the component library tracks zed HEAD, and the range carries its own "Update GPUI and fix API changes". Holding one back would put two gpui revisions in the tree, which the same-source rule incrates/gui/Cargo.tomlexists to prevent. It also brings a scrollbar repaint fix after a click on the track,max_linesontext_view, markdown tables styled from the theme'stable_*tokens, and a virtual list's stalecxin gpui-shell.Fallout in the lock
Eight transitive crates left the graph —
stackerandpsmbehind gpui's now opt-in stack growth, plus the secondrustix/linux-raw-syspair,ar_archive_writer,object,homeandwinsafe— andstrummoved to 0.28,whichto 8. Nothing in the workspace names any of them; they were all pulled in through zed.No source file changes: no API this client calls moved in any of the three ranges.
Verification
Cargo.lockis the whole diff, so the check that matters is that the tree still builds and passes against the new heads — left to CI here, which runscargo fmt,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspaceon all three platforms. A local full build on this machine is slower than the CI matrix by a wide margin, and it would be checking the same thing.Generated by Claude Code
Summary by cubic
Moves all branch-tracked git dependencies to their current heads; the entire diff is
Cargo.lockand no workspace source changes are needed.whatsapp-rustnow dispatches a resent message once instead of twice, which previously caused the chat store to write the row twice.Dependencies
gpui-componentmove together to keep a single gpui revision in the tree; the range fixes input handling and makes stack growth viastackeropt-in.stacker,psm, a duplicaterustix/linux-raw-syspair,home, andwinsafe.strummoved to 0.28 andwhichto 8.Written for commit d30c3c3. Summary will update on new commits.