Skip to content

Update docs for audit findings (correctness, safety, performance) - #152

Merged
mintlify[bot] merged 1 commit into
mainfrom
mintlify/audit-findings-1774752582
Mar 29, 2026
Merged

Update docs for audit findings (correctness, safety, performance)#152
mintlify[bot] merged 1 commit into
mainfrom
mintlify/audit-findings-1774752582

Conversation

@mintlify

@mintlify mintlify Bot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Updates documentation to reflect 9 audit findings from jlucaso1/whatsapp-rust#460 covering correctness bugs, safety improvements, and performance optimizations.

Changes

  • Signal protocol: Document sender key existence check using read-lock via SignalStoreCache and per-store independent flush during signal cache flush()
  • Events/receiving messages: Document UndecryptableMessage event dispatch for group NoSenderKeyState decrypt failures
  • Architecture/client: Document single cleanup_connection_state() call (removed duplicate in message loop)
  • Architecture: Document per-chat message queue capacity of 500 (reduced from 10000)
  • WebSocket handling: Document now_millis().max(0) guard for safe i64 to u64 timestamp casts
  • Receiving messages: Document type-safe JID classification methods (is_group(), is_broadcast_list(), is_status_broadcast())

@mintlify
mintlify Bot merged commit fe334ba into main Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants