Skip to content

docs: EncHandler wasm portability (whatsapp-rust#793) - #279

Merged
jlucaso1 merged 1 commit into
mainfrom
claude/eager-cerf-34if7e
Jun 9, 2026
Merged

jlucaso1 merged 1 commit into
mainfrom
claude/eager-cerf-34if7e

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Documents the fix from oxidezap/whatsapp-rust#793, which relaxed EncHandler's Send + Sync supertrait to MaybeSendSync and added a wasm32-gated async_trait(?Send).

Files changed:

  • changelog/2026-06-09.mdx — Added an EncHandler wasm portability entry to the "Fixes & hardening" section.
  • api/bot.mdx — Added a <Note> to the with_enc_handler section explaining that !Send JS handles are allowed on wasm32, while native targets keep Send + Sync via MaybeSendSync.

What changed in the library

EncHandler (the custom enc extension point registered via BotBuilder::with_enc_handler) previously required Send + Sync unconditionally, making it impossible to implement with !Send JS handles on the wasm32 port. The fix mirrors how EventHandler and SendContextResolver already handle this: use MaybeSendSync as the supertrait and gate async_trait with ?Send on wasm32. Native behaviour is unchanged.


Generated by Claude Code

- Append EncHandler wasm fix to changelog/2026-06-09.mdx
- Add wasm Note to with_enc_handler section in api/bot.mdx
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jlucaso1, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f3c65b39-2af0-4460-8841-0438e89b8177

📥 Commits

Reviewing files that changed from the base of the PR and between 6daf1ff and e8a741d.

📒 Files selected for processing (2)
  • api/bot.mdx
  • changelog/2026-06-09.mdx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/eager-cerf-34if7e

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mintlify

mintlify Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
whatsapp-rust 🟢 Ready View Preview Jun 9, 2026, 1:06 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@jlucaso1
jlucaso1 merged commit 2c39dbb into main Jun 9, 2026
2 checks passed
@jlucaso1
jlucaso1 deleted the claude/eager-cerf-34if7e branch June 9, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant