Skip to content

docs: Transport, TransportFactory, HttpClient now use MaybeSendSync (whatsapp-rust#795) - #281

Merged
jlucaso1 merged 1 commit into
mainfrom
claude/eager-cerf-ucum3s
Jun 9, 2026
Merged

jlucaso1 merged 1 commit into
mainfrom
claude/eager-cerf-ucum3s

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follows oxidezap/whatsapp-rust#795, which changed the supertrait of Transport, TransportFactory, and HttpClient from Send + Sync to MaybeSendSync — enabling !Send implementations on wasm32 (e.g. browser WebSocket / fetch handles) while keeping native behaviour identical.

  • api/transport.mdx — update Transport and TransportFactory trait signatures to show the MaybeSendSync supertrait and #[cfg_attr]-gated async_trait; add <Note> callouts explaining the wasm/native split; update Best Practices item 1 to reflect that Send + Sync is native-only.
  • api/http-client.mdx — same treatment for the HttpClient trait definition.
  • changelog/2026-06-09.mdx — add a "Networking traits wasm portability (#795)" entry alongside the existing EncHandler wasm entry.

Test plan

  • Verify trait code blocks in api/transport.mdx and api/http-client.mdx show MaybeSendSync and cfg_attr gates
  • Verify <Note> callouts appear after each trait definition
  • Verify Best Practices item 1 in api/transport.mdx no longer says "must be Send + Sync" unconditionally
  • Verify changelog entry links to PR #795 and appears after the EncHandler (#793) entry

Generated by Claude Code

…c wasm portability (PR #795)

Transport, TransportFactory, and HttpClient supertrait changed from
Send + Sync to MaybeSendSync — update trait signatures, add wasm notes,
update Best Practices, and add changelog entry.
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jlucaso1, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 32 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4496470d-366c-413d-bae6-8507b27d4f94

📥 Commits

Reviewing files that changed from the base of the PR and between 341c9e8 and 01d407c.

📒 Files selected for processing (3)
  • api/http-client.mdx
  • api/transport.mdx
  • changelog/2026-06-09.mdx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/eager-cerf-ucum3s

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jlucaso1
jlucaso1 merged commit bd6532a into main Jun 9, 2026
2 checks passed
@mintlify

mintlify Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
whatsapp-rust 🟢 Ready View Preview Jun 9, 2026, 2:02 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@jlucaso1
jlucaso1 deleted the claude/eager-cerf-ucum3s branch June 9, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant