docs: Transport, TransportFactory, HttpClient now use MaybeSendSync (whatsapp-rust#795) - #281
Conversation
…c wasm portability (PR #795) Transport, TransportFactory, and HttpClient supertrait changed from Send + Sync to MaybeSendSync — update trait signatures, add wasm notes, update Best Practices, and add changelog entry.
|
Warning Review limit reached
More reviews will be available in 32 minutes and 36 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Summary
Follows oxidezap/whatsapp-rust#795, which changed the supertrait of
Transport,TransportFactory, andHttpClientfromSend + SynctoMaybeSendSync— enabling!Sendimplementations onwasm32(e.g. browser WebSocket /fetchhandles) while keeping native behaviour identical.api/transport.mdx— updateTransportandTransportFactorytrait signatures to show theMaybeSendSyncsupertrait and#[cfg_attr]-gatedasync_trait; add<Note>callouts explaining the wasm/native split; update Best Practices item 1 to reflect thatSend + Syncis native-only.api/http-client.mdx— same treatment for theHttpClienttrait definition.changelog/2026-06-09.mdx— add a "Networking traits wasm portability (#795)" entry alongside the existingEncHandlerwasm entry.Test plan
api/transport.mdxandapi/http-client.mdxshowMaybeSendSyncandcfg_attrgates<Note>callouts appear after each trait definitionapi/transport.mdxno longer says "must beSend + Sync" unconditionallyEncHandler(#793) entryGenerated by Claude Code