docs: contacts async_trait / boxed-future fix (whatsapp-rust#826) - #303
Conversation
|
Warning Review limit reached
More reviews will be available in 46 minutes and 45 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Summary\n\nDocumentation update for oxidezap/whatsapp-rust#826, which fixed
is_on_whatsapp()andget_user_info()failing to compile for consumers that box their futures (the pattern#[async_trait]uses).\n\n- Newchangelog/2026-06-10-hrtb-closures.mdx— explains the root cause (HRTB-violating closures inside the library's future types), the fix (namedfnitems), and the regression guard added in the same PR\n- Updatedapi/contacts.mdx— adds an "Async compatibility" section noting both affected methods now work correctly in#[async_trait]andBox<dyn Future>contexts, with a link to the fix\n- Updateddocs.json— registers the new changelog page in the navigation\n\n## Test plan\n\n- [ ] Verify the new changelog page renders in the Changelog tab\n- [ ] Verify the "Async compatibility" section appears in the Contacts API page between "Privacy & TC tokens" and "Error handling"\n- [ ] Confirm no existing content was changed beyond the new section insertionGenerated by Claude Code