Skip to content

docs: contacts async_trait / boxed-future fix (whatsapp-rust#826) - #303

Merged
jlucaso1 merged 1 commit into
mainfrom
claude/eager-cerf-7tcsxb
Jun 10, 2026
Merged

docs: contacts async_trait / boxed-future fix (whatsapp-rust#826)#303
jlucaso1 merged 1 commit into
mainfrom
claude/eager-cerf-7tcsxb

Conversation

@jlucaso1

Copy link
Copy Markdown
Collaborator

Summary\n\nDocumentation update for oxidezap/whatsapp-rust#826, which fixed is_on_whatsapp() and get_user_info() failing to compile for consumers that box their futures (the pattern #[async_trait] uses).\n\n- New changelog/2026-06-10-hrtb-closures.mdx — explains the root cause (HRTB-violating closures inside the library's future types), the fix (named fn items), and the regression guard added in the same PR\n- Updated api/contacts.mdx — adds an "Async compatibility" section noting both affected methods now work correctly in #[async_trait] and Box<dyn Future> contexts, with a link to the fix\n- Updated docs.json — registers the new changelog page in the navigation\n\n## Test plan\n\n- [ ] Verify the new changelog page renders in the Changelog tab\n- [ ] Verify the "Async compatibility" section appears in the Contacts API page between "Privacy & TC tokens" and "Error handling"\n- [ ] Confirm no existing content was changed beyond the new section insertion


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jlucaso1, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f675ea5-cdc4-42fa-8da4-46eb10b996c7

📥 Commits

Reviewing files that changed from the base of the PR and between b6037c4 and 1293045.

📒 Files selected for processing (3)
  • api/contacts.mdx
  • changelog/2026-06-10-hrtb-closures.mdx
  • docs.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/eager-cerf-7tcsxb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mintlify

mintlify Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
whatsapp-rust 🟢 Ready View Preview Jun 10, 2026, 11:37 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@jlucaso1
jlucaso1 merged commit 5f43487 into main Jun 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant