Skip to content

docs: drop moka, update cache docs for PortableCache (whatsapp-rust#860) - #327

Merged
jlucaso1 merged 2 commits into
mainfrom
claude/eager-cerf-7di2zp
Jun 14, 2026
Merged

jlucaso1 merged 2 commits into
mainfrom
claude/eager-cerf-7di2zp

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follows whatsapp-rust#860, which removes the moka dependency and makes PortableCache the sole in-process cache backend on every target.

  • installation.mdx — Remove moka-cache feature from all code examples and the feature-flags table (feature no longer exists)
  • concepts/storage.mdx — Replace all moka references with PortableCache; update PortableCache section to describe it as the sole backend (not a WASM-only fallback); document new capabilities (monotonic TTL/TTI, eager init-lock reclamation, clear(), snapshot_entries()); update TypedCache::from_mokafrom_local in examples; update mermaid diagram
  • guides/custom-backends.mdx — Minor reference updates in the custom cache store section
  • changelog/2026-06-14-drop-moka-portable-cache.mdx — New changelog entry with binary size table and breaking-change migration guide
  • docs.json — Register new changelog page

Test plan

  • Verify no moka or moka-cache references remain in updated files
  • Confirm changelog entry renders correctly on the docs site
  • Check that stable-Rust feature list examples compile without moka-cache

https://claude.ai/code/session_01BkboFWXpkvp9HyHs1t4djA


Generated by Claude Code


Summary by cubic

Updates the docs to remove moka and document PortableCache as the sole in-process cache backend. Cleans up remaining references in API docs and the pt locale, and adds a changelog with size impact and a migration guide.

  • New Features

    • Documented PortableCache as the default on all targets (incl. wasm32) with single-flight get_with.
    • Added capabilities: monotonic TTL/TTI, eager init-lock reclamation, reliable async clear(), and snapshot_entries().
    • Updated TypedCache docs: from_local replaces from_moka; clarified invalidate_all (best-effort) vs clear (awaited) and run_pending_tasks (in-process only).
    • Replaced moka mentions across storage, advanced/state-management (clear() on reconnect), signal-protocol (single-flight), custom-backends, API pages, and pt/installation.mdx. Removed moka-cache from feature tables and examples.
  • Migration

    • Remove the moka-cache feature from your Cargo.toml.
    • Rename TypedCache::from_moka to TypedCache::from_local.
    • Drop any cfg gating for the portable_cache module (it is now always available).

Written for commit c8d264c. Summary will update on new commits.

Review in cubic

- Remove `moka-cache` feature from installation guides and stable-Rust
  code examples (feature no longer exists)
- Replace all moka references with PortableCache throughout storage and
  custom-backends docs; rename `TypedCache::from_moka` → `from_local`
- Update PortableCache section to reflect it is now the sole in-process
  cache backend on every target (not a WASM-only fallback)
- Document new PortableCache capabilities: monotonic TTL/TTI, eager
  init-lock reclamation, reliable async clear(), snapshot_entries()
- Add changelog entry for PR #860 including binary size impact table
  and breaking-change migration guide

https://claude.ai/code/session_01BkboFWXpkvp9HyHs1t4djA
@mintlify

mintlify Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
whatsapp-rust 🟢 Ready View Preview Jun 14, 2026, 12:15 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jlucaso1, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 6 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 65456b8d-c012-488c-a119-9d538b5dd915

📥 Commits

Reviewing files that changed from the base of the PR and between 5292bb9 and c8d264c.

📒 Files selected for processing (10)
  • advanced/signal-protocol.mdx
  • advanced/state-management.mdx
  • api/bot.mdx
  • api/store.mdx
  • changelog/2026-06-14-drop-moka-portable-cache.mdx
  • concepts/storage.mdx
  • docs.json
  • guides/custom-backends.mdx
  • installation.mdx
  • pt/installation.mdx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/eager-cerf-7di2zp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: deec116f3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread changelog/2026-06-14-drop-moka-portable-cache.mdx
Comment thread changelog/2026-06-14-drop-moka-portable-cache.mdx
Address Codex review findings:
- pt/installation.mdx: remove moka-cache feature from stable-Rust
  examples and feature flags table (matches en/installation.mdx fix)
- api/store.mdx: update TypedCache docs — from_moka → from_local,
  update method table descriptions for in-process vs custom-store path
- api/bot.mdx: replace "default in-process moka behavior" reference
- advanced/state-management.mdx: replace moka Cache ref with
  PortableCache; update chat_lanes clear() semantics
- advanced/signal-protocol.mdx: replace two moka references with
  PortableCache (SenderKeyDeviceCache coalescing, session_recreate_history)

https://claude.ai/code/session_01BkboFWXpkvp9HyHs1t4djA
@jlucaso1
jlucaso1 merged commit a35417b into main Jun 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants