docs: tctoken attach/issue on outgoing VoIP call offers for #970 - #376
Conversation
…rust#970 Documents place_call attaching the callee's stored token to the offer's <privacy> node and issuing a fresh token after send, and that this path has no AB prop gate unlike the message/usync/spam-report paths.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Pure documentation updates adding details about tctoken behavior in VoIP calls. No code changes, no risk of breaking functionality.
Re-trigger cubic
Reword the intro line so it doesn't imply the VoIP call-offer path is AB-prop-gated like the other two, and add the VoIP path to the token lifecycle sequence diagram.
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Documentation updates describing automated TC token handling for VoIP call offers.
Re-trigger cubic
Per Greptile's nit, the note overstated issuance as happening after every offer instead of only when the sender-side bucket rolls over.
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Documentation updates for tctoken attachment in VoIP calls.
Re-trigger cubic
Summary
whatsapp-rust#970 closed the last documented gap in the trusted-contact token sweep: outgoing 1:1 VoIP call offers now attach the callee's stored tctoken and issue a fresh one after the offer sends (matching WA Web's
sendTcTokeninStartCall.js).api/tctoken.mdx's "Automatic usage" section already enumerates every other attachment point (messages, profile pictures, usync, spam report) and would otherwise go stale, andguides/voip-calls.mdxdocuments placing an outgoing call with no mention of privacy-token handling.Changes
api/tctoken.mdx: added outgoing call offers as a third "no cstoken fallback" attachment point in "Automatic usage", with a code snippet. Noted in "AB prop gating" that this path is unconditional — no AB prop gates it, unlike the message/usync/spam-report paths, which is the one point worth calling out since every other automatic-attachment path documented here is gated.guides/voip-calls.mdx: added a note under "Placing an Outgoing Call" pointing to the TC Token docs, so callers know the behavior is automatic and don't go looking for a manual API.No changelog changes included, per instructions.
Ref: oxidezap/whatsapp-rust#970
Generated by Claude Code
Summary by cubic
Documented automatic trusted-contact token attach and conditional post-send issuance for outgoing 1:1 VoIP call offers, matching WhatsApp Web’s
sendTcTokeninStartCall.js. Clarified this path is ungated and that reissuance runs only when the sender-side bucket has rolled over, and added the flow to the lifecycle diagram to prevent 463 nacks with privacy-restricted contacts.Written for commit a331f42. Summary will update on new commits.