docs: document critical app-state sync deadline - #384
Conversation
Adds a "Critical app-state sync (pairing bootstrap)" subsection under Connection Lifecycle describing the 180s critical-sync deadline, the 10s auto-shared-key grace, and the deadline-bounded AppStateSyncKeyRequest fallback that lets a late/never-auto-shared key still recover on the same connection instead of stalling to the watchdog reconnect.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds documentation for critical app-state sync deadline. No code changes, only a new subsection in an architecture doc.
Re-trigger cubic
|
| Filename | Overview |
|---|---|
| concepts/architecture.mdx | Adds "Critical app-state sync (pairing bootstrap)" subsection documenting the 180s deadline, 10s key-share grace, and deadline-bounded key-request fallback; also fixes missing trailing newline. |
Reviews (2): Last reviewed commit: "fix: restore accidentally-dropped peer-l..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
…ment Greptile caught two regressions introduced in the previous commit while transcribing the file: the "appstate" module comment was mistakenly changed from "App state sync protocol" to "App state management", and the sentence documenting single-device peer-message session locking was silently dropped from the "Per-device session locks" section. Neither was an intentional change; both are restored verbatim.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Auto-approved: Documentation-only change: adds a new subsection on critical app-state sync timing to the architecture docs. No code or logic changes.
Re-trigger cubic
1 participant
Summary
concepts/architecture.mdx, right after the existing "Offline sync" subsection.CRITICAL_SYNC_TIMEOUT_SECSdeadline (matching WhatsApp Web'sWAWebSyncBootstrap) that now bounds the whole critical app-state sync path at pairing/reconnect: the watchdog-first arming, the 10s auto-shared-key grace, and the deadline-boundedAppStateSyncKeyRequestfallback that lets a late or never-auto-shared key still recover on the same connection instead of stalling until the watchdog forces a reconnect.server_sync,ibdirty-resync) are unaffected and keep the fixed 10s key wait.No other user-facing behavior changed in the source PR (the rest of the diff is internal signature changes and a new regression test), so no other doc pages needed updates.
Test plan
mint broken-links(if available) to confirm no broken links were introduced🤖 Generated with Claude Code
Generated by Claude Code
Summary by cubic
Document the critical app-state sync deadline for pairing bootstrap. A single 180s window covers the watchdog, a 10s key-share grace, and a deadline-bounded
AppStateSyncKeyRequest, so late or missing keys can recover on the same connection. Adds a "Critical app-state sync (pairing bootstrap)" subsection under Connection Lifecycle and notes that non-critical sync keeps the fixed 10s key wait.appstatemodule comment.Written for commit c250cd1. Summary will update on new commits.