docs: document legacy session v1 interop and duplicate-vs-BadMac ranking - #425
Conversation
…ing (whatsapp-rust#1072) Documents the new opt-in legacy-session-interop feature (typed import/export between decoded libsignal SessionRecord v1 and the canonical record, for migration tooling) and the decrypt-path change where a recognized duplicate now outranks BadMac and the skipped-key search continues into archived sessions, including closed receiver chains.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
| Filename | Overview |
|---|---|
| advanced/signal-protocol.mdx | Adds legacy session v1 interoperability documentation and explains duplicate-message search and error ranking. |
Reviews (1): Last reviewed commit: "docs: document legacy session v1 interop..." | Re-trigger Greptile
Summary
Documents whatsapp-rust#1072 "feat(signal): add typed legacy session interop" in
advanced/signal-protocol.mdx:legacy-session-interopCargo feature, the typed decoded-v1 model (LegacySessionRecordV1,LegacySessionV1, etc.), the import path (LegacySessionRecordV1::from_indexed_sessions→into_session_record), the operational (non-byte-exact) export path (SessionRecord::into_legacy_session_v1_operational), thepreviousCounter = -1floor, and the typed rejection errors for non-representable state.DuplicatedMessagefrom one session no longer aborts the search — it continues into archived sessions and closed receiver chains — and a recognized duplicate now outranksBadMacin the final error classification, so a replay is acknowledged instead of triggering a spurious retry receipt.Test plan
wacore/libsignal/src/protocol/legacy_session.rs), and Cargo.toml feature wiring to verify the described public API and behaviorGenerated by Claude Code
Summary by cubic
Documents the new opt-in
legacy-session-interopfor typed import/export between decoded legacySessionRecordv1 and the canonical record, and clarifies duplicate message handling in the decrypt path. Also covers continued search into archived/closed chains and rankingDuplicatedMessageaboveBadMac.legacy-session-interopinwacore-libsignal; import viaLegacySessionRecordV1::from_indexed_sessions→into_session_record; export viaSessionRecord::into_legacy_session_v1_operational; floorsprevious_counter = -1to0; rejects non-representable state with typed errors; secrets redacted inDebug.DuplicatedMessageno longer ends the search; archived sessions and closed receiver chains are tried; final error prefersDuplicatedMessageoverBadMacto avoid spurious retry receipts.Written for commit 4d10589. Summary will update on new commits.