Skip to content

docs: document legacy session v1 interop and duplicate-vs-BadMac ranking - #425

Merged
jlucaso1 merged 1 commit into
mainfrom
claude/nifty-bohr-zs2qwh
Jul 23, 2026
Merged

docs: document legacy session v1 interop and duplicate-vs-BadMac ranking#425
jlucaso1 merged 1 commit into
mainfrom
claude/nifty-bohr-zs2qwh

Conversation

@jlucaso1

@jlucaso1 jlucaso1 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

Documents whatsapp-rust#1072 "feat(signal): add typed legacy session interop" in advanced/signal-protocol.mdx:

  • New Legacy session v1 interop subsection under "Record components" — the opt-in legacy-session-interop Cargo feature, the typed decoded-v1 model (LegacySessionRecordV1, LegacySessionV1, etc.), the import path (LegacySessionRecordV1::from_indexed_sessionsinto_session_record), the operational (non-byte-exact) export path (SessionRecord::into_legacy_session_v1_operational), the previousCounter = -1 floor, and the typed rejection errors for non-representable state.
  • Extended Duplicate message detection (under Security Considerations) to cover the decrypt-path behavior that ships unconditionally (not feature-gated): a DuplicatedMessage from one session no longer aborts the search — it continues into archived sessions and closed receiver chains — and a recognized duplicate now outranks BadMac in the final error classification, so a replay is acknowledged instead of triggering a spurious retry receipt.

Test plan

  • Read the merged PR's diff, new module (wacore/libsignal/src/protocol/legacy_session.rs), and Cargo.toml feature wiring to verify the described public API and behavior
  • Docs site preview (Mintlify) renders the new section and anchors correctly

Generated by Claude Code


Summary by cubic

Documents the new opt-in legacy-session-interop for typed import/export between decoded legacy SessionRecord v1 and the canonical record, and clarifies duplicate message handling in the decrypt path. Also covers continued search into archived/closed chains and ranking DuplicatedMessage above BadMac.

  • New Features
    • Legacy session v1 interop: behind legacy-session-interop in wacore-libsignal; import via LegacySessionRecordV1::from_indexed_sessionsinto_session_record; export via SessionRecord::into_legacy_session_v1_operational; floors previous_counter = -1 to 0; rejects non-representable state with typed errors; secrets redacted in Debug.
    • Duplicate detection: a DuplicatedMessage no longer ends the search; archived sessions and closed receiver chains are tried; final error prefers DuplicatedMessage over BadMac to avoid spurious retry receipts.

Written for commit 4d10589. Summary will update on new commits.

…ing (whatsapp-rust#1072)

Documents the new opt-in legacy-session-interop feature (typed import/export
between decoded libsignal SessionRecord v1 and the canonical record, for
migration tooling) and the decrypt-path change where a recognized duplicate
now outranks BadMac and the skipped-key search continues into archived
sessions, including closed receiver chains.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jlucaso1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d1aad57b-3aea-41da-a0b3-a2724c8eb999

📥 Commits

Reviewing files that changed from the base of the PR and between df10074 and 4d10589.

📒 Files selected for processing (1)
  • advanced/signal-protocol.mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mintlify

mintlify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
whatsapp-rust 🟢 Ready View Preview Jul 23, 2026, 1:33 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR documents legacy session interoperability and revised duplicate-message handling. The main changes are:

  • Adds the feature-gated legacy session v1 import and export APIs.
  • Describes migration validation, representability errors, and secret redaction.
  • Explains continued session search after duplicate detection.
  • Documents the final ranking of DuplicatedMessage over BadMac.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed documentation.

Important Files Changed

Filename Overview
advanced/signal-protocol.mdx Adds legacy session v1 interoperability documentation and explains duplicate-message search and error ranking.

Reviews (1): Last reviewed commit: "docs: document legacy session v1 interop..." | Re-trigger Greptile

@jlucaso1
jlucaso1 merged commit eb41e9a into main Jul 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants