perf(size): -1.47 MiB (-13.3%) stripped binary — build-config levers + control-plane demonomorphization

.cargo/config.toml

@@ -0,0 +1,34 @@
+# Workspace build configuration. Applies to builds of THIS repo only —
+# crates.io consumers are unaffected (cargo does not inherit this file
+# across package boundaries).
+
+[target.x86_64-unknown-linux-gnu]
+# -Zshare-generics=y: downstream crates reuse upstream monomorphic
+#   instantiations instead of stamping per-crate copies with distinct symbol
+#   hashes that fat LTO cannot merge (measured -335 KiB on the stripped demo;
+#   the Docker image build already ran with this flag). Nightly-only, and the
+#   toolchain is pinned by rust-toolchain.toml.
+# lld + ICF: lld lays out the fat-LTO object tighter than BFD ld and folds
+#   byte-identical sections (measured -73 KiB on the stripped demo). Scoped to
+#   this target so wasm and non-Linux builds keep their default linkers.
+#   -Clinker-features=+lld selects the rust-lld bundled with the pinned
+#   toolchain, so contributors need no system lld package. Still
+#   unstable-gated on this nightly, hence -Zunstable-options (the block is
+#   nightly-only anyway; CI's stable job opts out via RUSTFLAGS="").
+rustflags = [
+    "-Zshare-generics=y",
+    "-Zunstable-options",
+    "-Clinker-features=+lld",
+    "-Clink-arg=-Wl,--icf=all",
+]
+
+[env]
+# Trim bundled-SQLite subsystems the workspace never touches. FTS5 stays:
+# chat-store's `search` feature builds its index on it. Shared cache stays:
+# sqlite-storage's in-memory mode shares one DB across the pool via
+# `cache=shared` URIs. JSON and extension loading are unused by
+# diesel/sqlite-storage/chat-store (checked: no json_* SQL, no
+# load_extension callers); dropping loadable extensions also removes a
+# dlopen surface. STAT4/DBSTAT/RTREE/FTS3/SOUNDEX are upstream-default-off
+# features libsqlite3-sys turns on; none are exercised here.
+LIBSQLITE3_FLAGS = "-USQLITE_ENABLE_FTS3 -USQLITE_ENABLE_FTS3_PARENTHESIS -USQLITE_ENABLE_RTREE -USQLITE_ENABLE_STAT4 -USQLITE_ENABLE_DBSTAT_VTAB -USQLITE_SOUNDEX -DSQLITE_OMIT_JSON -DSQLITE_OMIT_LOAD_EXTENSION -DSQLITE_OMIT_DEPRECATED -DSQLITE_OMIT_PROGRESS_CALLBACK"

.github/workflows/main.yml

@@ -150,6 +150,11 @@ jobs:
   test-stable:
     name: Test Stable (no-simd)
     runs-on: ubuntu-latest
+    # .cargo/config.toml sets nightly-only rustflags (-Zshare-generics) for the
+    # x86_64-linux target; a set-but-empty RUSTFLAGS takes precedence over
+    # config rustflags, keeping this stable-toolchain job buildable.
+    env:
+      RUSTFLAGS: ""
     steps:
       - uses: actions/checkout@v6
       - uses: dtolnay/rust-toolchain@stable

.gitignore

@@ -2,7 +2,8 @@
 /*.xml
 /*.txt
 /whatsapp_store
-/.cargo
+/.cargo/*
+!/.cargo/config.toml
 /.vscode
 /*.db*
 .env

Cargo.toml

@@ -301,6 +301,11 @@ opt-level = "s"
 opt-level = "s"
 [profile.release.package.serde_json]
 opt-level = "s"
+# The bundled SQLite amalgamation (sqlite3.c) — cargo exports OPT_LEVEL to the
+# build script and the cc crate maps it to -Oz. The C core was the one crate
+# the per-package sweep above missed; same I/O-bound tradeoff as diesel.
+[profile.release.package.libsqlite3-sys]
+opt-level = "z"
 
 # Benchmark profile: release-grade codegen, but thin LTO keeps bench builds
 # fast (release uses fat LTO) and debug symbols stay for local profiling.

clippy.toml

@@ -3,6 +3,21 @@ disallowed-methods = [
     { path = "chrono::Local::now", reason = "use wacore::time::now_utc() (Local depends on SystemTime which panics on WASM)" },
     { path = "std::time::SystemTime::now", reason = "use wacore::time::now_millis() / now_utc()" },
     { path = "std::time::Instant::now", reason = "use wacore::time::Instant::now()" },
+    # buffa's Message codec methods are generic over the buffer type, so every
+    # calling crate stamps its own copy of the full encode/decode tree (LTO
+    # cannot merge them). Route waproto types through the pinned wrappers in
+    # waproto::codec — add one there if missing. Crate-local protos (their sole
+    # instantiation site) and tests carry a scoped allow instead.
+    { path = "buffa::message::Message::encode_to_vec", reason = "use waproto::codec::*_to_vec (pinned single instantiation; direct calls duplicate the encode tree per crate)" },
+    { path = "buffa::message::Message::encode", reason = "use waproto::codec::*_encode_into (pinned single instantiation; direct calls duplicate the encode tree per crate)" },
+    { path = "buffa::message::Message::write_to", reason = "use waproto::codec::*_write_to (pinned single instantiation; direct calls duplicate the encode tree per crate)" },
+    { path = "buffa::message::Message::decode_from_slice", reason = "use waproto::codec::*_decode (pinned single instantiation; direct calls duplicate the decode tree per crate)" },
+    { path = "buffa::message::Message::merge_from_slice", reason = "use waproto::codec::*_merge (pinned single instantiation; direct calls duplicate the decode tree per crate)" },
+    { path = "buffa::message::Message::merge_to_limit", reason = "use a waproto::codec pinned wrapper (direct calls duplicate the decode tree per crate)" },
+    { path = "buffa::message::Message::decode", reason = "use a waproto::codec pinned wrapper (direct calls duplicate the decode tree per crate)" },
+    { path = "buffa::message::Message::decode_length_delimited", reason = "use a waproto::codec pinned wrapper (direct calls duplicate the decode tree per crate)" },
+    { path = "buffa::message::Message::encode_length_delimited", reason = "use a waproto::codec pinned wrapper (direct calls duplicate the encode tree per crate)" },
+    { path = "buffa::message::Message::encode_to_bytes", reason = "use a waproto::codec pinned wrapper (direct calls duplicate the encode tree per crate)" },
 ]
 
 # 64-bit atomic *types*: 32-bit targets (Xtensa/ESP32) have no native AtomicU64/

src/appstate_sync.rs

@@ -3,6 +3,7 @@ pub use wacore::appstate::Mutation;
 pub use wacore::appstate_sync::{AppStateProcessor, AppStateSyncDriver, AppStateSyncError};
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::*;
     use async_lock::Mutex;

src/bot.rs

@@ -1305,7 +1305,26 @@ impl BotBuilder<Provided, Provided, Provided, Provided> {
         if let Some(override_) = self.device_props_override
             && !override_.is_empty()
         {
-            info!("Applying device props override: {:?}", override_);
+            // Field-by-field to avoid Debug-formatting waproto types (keeps their
+            // generated Debug impls out of the binary).
+            info!(
+                "Applying device props override: os={:?} version={:?} platform_type={:?} history_sync_config={}",
+                override_.os.as_deref(),
+                override_.version.as_ref().map(|v| {
+                    format!(
+                        "{}.{}.{}",
+                        v.primary.unwrap_or(0),
+                        v.secondary.unwrap_or(0),
+                        v.tertiary.unwrap_or(0)
+                    )
+                }),
+                override_.platform_type.map(|p| p as i32),
+                if override_.history_sync_config.is_some() {
+                    "overridden"
+                } else {
+                    "default"
+                },
+            );
             persistence_manager
                 .process_command(DeviceCommand::SetDeviceProps(override_))
                 .await;

src/client/device_registry.rs

@@ -1029,6 +1029,7 @@ impl Client {
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::*;
     use crate::lid_pn_cache::LearningSource;

src/client/lid_pn.rs

@@ -1000,6 +1000,7 @@ impl Client {
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::*;
     use crate::lid_pn_cache::LearningSource;

src/features/message_edit.rs

@@ -536,6 +536,7 @@ pub fn decrypt_secret_encrypted_with_fallback(
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::*;
     use wacore::message_edit::encrypt_message_edit;

src/features/mex.rs

@@ -113,14 +113,20 @@ impl<'a> Mex<'a> {
         self.execute_request(request).await
     }
 
+    #[inline]
     async fn execute_request<V: Serialize>(
         &self,
         request: MexRequest<V>,
     ) -> Result<MexResponse, MexError> {
         // Serialize the variables here so a caller-side serialization error
         // surfaces as MexError::Json instead of a malformed empty request.
         let spec = MexQuerySpec::new(request.doc, &request.variables)?;
+        self.execute_spec(spec).await
+    }
 
+    // Non-generic so the execute/error-handling body instantiates once, not
+    // per variables type.
+    async fn execute_spec(&self, spec: MexQuerySpec) -> Result<MexResponse, MexError> {
         let response = self.client.execute(spec).await?;
 
         // Check for fatal errors (the IqSpec already checks, but we want to return our error type)

src/features/rotate_key.rs

@@ -7,12 +7,10 @@
 
 use crate::client::Client;
 use crate::request::IqError;
-use buffa::Message;
 use wacore::iq::prekeys::RotateSignedPreKeySpec;
 use wacore::libsignal::protocol::{KeyPair, PrivateKey, PublicKey};
 use wacore::libsignal::store::record_helpers::new_signed_pre_key_record;
 use wacore::store::commands::DeviceCommand;
-use waproto::whatsapp::SignedPreKeyRecordStructure;
 
 /// Rotation cadence. This is the one value NOT grounded in the WA Web bundle
 /// (there it is a persisted background job with a server-tuned schedule), so
@@ -110,7 +108,7 @@ impl Client {
             .map_err(|e| anyhow::anyhow!("failed to load staged signed pre-key: {e}"))?
         {
             Some(bytes) => {
-                let s = SignedPreKeyRecordStructure::decode_from_slice(&bytes)
+                let s = waproto::codec::signed_pre_key_record_decode(&bytes)
                     .map_err(|e| anyhow::anyhow!("staged signed pre-key decode: {e}"))?;
                 let public = PublicKey::from_djb_public_key_bytes(
                     s.public_key
@@ -143,7 +141,10 @@ impl Client {
                 let record =
                     new_signed_pre_key_record(new_id, &kp, signature, wacore::time::now_utc());
                 backend
-                    .store_signed_prekey(new_id, &record.encode_to_vec())
+                    .store_signed_prekey(
+                        new_id,
+                        &waproto::codec::signed_pre_key_record_to_vec(&record),
+                    )
                     .await
                     .map_err(|e| anyhow::anyhow!("failed to stage new signed pre-key: {e}"))?;
                 (kp, signature)
@@ -161,7 +162,10 @@ impl Client {
             wacore::time::now_utc(),
         );
         backend
-            .store_signed_prekey(old_id, &old_record.encode_to_vec())
+            .store_signed_prekey(
+                old_id,
+                &waproto::codec::signed_pre_key_record_to_vec(&old_record),
+            )
             .await
             .map_err(|e| anyhow::anyhow!("failed to retain old signed pre-key: {e}"))?;
 

src/history_sync.rs

@@ -625,6 +625,7 @@ fn push_unique_sender(senders: &mut Vec<Jid>, sender: Jid) {
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::*;
     use buffa::Message as ProtoMessage;

src/message/msg_secret.rs

@@ -464,12 +464,10 @@ impl Client {
         info: &Arc<MessageInfo>,
         payload: EncPayload,
     ) {
-        use buffa::Message as _;
-        use wa::MessageSecretMessage;
         use wacore::bot_message::{BotMessageContext, decrypt_bot_message};
         use wacore::protocol::nack::NackReason;
 
-        let ms_msg = match MessageSecretMessage::decode_from_slice(&payload.ciphertext) {
+        let ms_msg = match waproto::codec::message_secret_message_decode(&payload.ciphertext) {
             Ok(m) => m,
             Err(e) => {
                 log::warn!(

src/message/special.rs

@@ -1,7 +1,6 @@
 //! Special message types: newsletter, app-state key share, sender-key distribution.
 
 use super::*;
-use buffa::Message as _;
 
 const APP_STATE_KEY_SHARE_SEND_ATTEMPTS: u8 = 3;
 const APP_STATE_KEY_SHARE_SEND_RETRY: std::time::Duration = std::time::Duration::from_secs(1);
@@ -90,7 +89,9 @@ impl Client {
             Some(KeyComponents {
                 key_id,
                 data,
-                fingerprint_bytes: fingerprint.encode_to_vec(),
+                fingerprint_bytes: waproto::codec::app_state_sync_key_fingerprint_to_vec(
+                    fingerprint,
+                ),
                 timestamp: key_data.timestamp.unwrap_or_default(),
             })
         }
@@ -182,9 +183,7 @@ impl Client {
                 continue;
             };
             let key_data = if let Some(stored) = key_store.get_sync_key(key_id).await? {
-                match wa::message::AppStateSyncKeyFingerprint::decode_from_slice(
-                    &stored.fingerprint,
-                ) {
+                match waproto::codec::app_state_sync_key_fingerprint_decode(&stored.fingerprint) {
                     Ok(fingerprint) => {
                         buffa::MessageField::some(wa::message::AppStateSyncKeyData {
                             key_data: Some(stored.key_data),

src/message/tests.rs

@@ -1,5 +1,8 @@
 //! Tests for the message receive/decrypt pipeline.
 
+// Tests/benches exercise the raw buffa API.
+#![allow(clippy::disallowed_methods)]
+
 use super::*;
 use crate::store::SqliteStore;
 use crate::store::persistence_manager::PersistenceManager;

src/passkey/flow.rs

@@ -617,6 +617,7 @@ pub(crate) async fn handle_passkey_continuation(client: &Arc<Client>, node: Arc<
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::*;
     use crate::test_utils::{TestEventCollector, create_test_client, node_to_owned_ref};

src/pdo.rs

@@ -568,6 +568,7 @@ impl Client {
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod tests {
     use super::self_peer_target;
     use wacore::store::Device;

src/prekeys.rs

@@ -1058,6 +1058,7 @@ mod tests {
 }
 
 #[cfg(test)]
+#[allow(clippy::disallowed_methods)]
 mod window_tests {
     use wacore::libsignal::protocol::PublicKey;
 

src/reexports_test.rs

@@ -2,6 +2,8 @@
 //! implement the async traits using only this crate's re-exports (no direct
 //! buffa/bytes/anyhow/async-trait/chrono dependency of its own).
 #![cfg(test)]
+// Tests/benches exercise the raw buffa API.
+#![allow(clippy::disallowed_methods)]
 
 use crate as whatsapp_rust;
 use whatsapp_rust::waproto::whatsapp as wa;