Skip to content

perf(messages): draw the pad length from the thread RNG #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 1 commit into from
Jul 29, 2026
Merged

perf(messages): draw the pad length from the thread RNG #1189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion wacore/src/messages.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ impl core::fmt::Write for Utf8Sink<'_> {
impl MessageUtils {
fn random_pad_len() -> u8 {
use rand::RngExt;
let mut rng = rand::make_rng::<rand::rngs::StdRng>();
// The thread-local generator directly: seeding a fresh StdRng per
// plaintext ran a full ChaCha key schedule to produce one byte.
let mut rng = rand::rng();
// Uniform 1..=16, matching WA Web / whatsmeow (rand%16 + 1). The prior
// `& 0x0F` with a 0->15 remap skewed toward 15 and never produced 16.
(rng.random::<u8>() & 0x0F) + 1
Expand Down
Loading