Skip to content

refactor(deps): drop redundant crates and unused dependency features #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 2 commits into from
Jul 30, 2026
Merged

refactor(deps): drop redundant crates and unused dependency features #1200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50dbe13
refactor(deps): drop redundant crates and unused dependency features
claude Jul 30, 2026
79c680b
fix(deps): keep the surfaces the removed derives had guaranteed
claude Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 0 additions & 98 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ unused_qualifications = "warn"

[workspace.dependencies]
aes = "0.9.2"
aes-gcm = { version = "0.11.0", default-features = false, features = ["aes", "alloc", "bytes"] }
aes-gcm = { version = "0.11.0", default-features = false, features = ["aes", "alloc"] }
anyhow = { version = "1.0", default-features = false }
async-channel = { version = "2.5.0", default-features = false, features = ["std"] }
async-lock = { version = "3", default-features = false }
Expand All @@ -85,7 +85,6 @@ bon = { version = "3.9.3", default-features = false, features = ["std"] }
buffa = { version = "0.9.1", default-features = false, features = ["json"] }
buffa-build = { version = "0.9.1", default-features = false }
buffa-descriptor = { version = "0.9.1", default-features = false }
bytemuck = { version = "1.25", default-features = false }
bytes = { version = "1.12", default-features = false }
cbc = { version = "0.2", features = ["alloc"] }
chrono = { version = "0.4", default-features = false }
Expand All @@ -99,7 +98,7 @@ event-listener = { version = "5", default-features = false }
flate2 = { version = "1.1.9", default-features = false, features = ["zlib-rs"] }
futures = { version = "0.3", default-features = false, features = ["alloc", "async-await"] }
getrandom = { version = "0.4", default-features = false }
hashbrown = { version = "0.17.1", default-features = false, features = ["equivalent"] }
hashbrown = { version = "0.17.1", default-features = false }
heck = "0.5"
hex = { version = "0.4", default-features = false, features = ["alloc"] }
hkdf = { version = "0.13.0", default-features = false }
Expand Down Expand Up @@ -207,7 +206,9 @@ base64 = { workspace = true }
bon = { workspace = true, optional = true }
buffa = { workspace = true }
bytes = { workspace = true }
chrono = { workspace = true, features = ["clock"] }
# `now` rather than `clock`: only `Utc::now()` is used, and `clock` exists to
# resolve the local timezone (pulling iana-time-zone and its per-OS backends).
chrono = { workspace = true, features = ["now"] }
Comment thread
jlucaso1 marked this conversation as resolved.
event-listener = { workspace = true }
futures = { workspace = true, features = ["std"] }
smallvec = { workspace = true }
Expand Down Expand Up @@ -252,7 +253,6 @@ getrandom = { workspace = true, features = ["wasm_js"] }

[dev-dependencies]
aes = { workspace = true }
async-trait = { workspace = true }
cbc = { workspace = true, features = ["block-padding"] }
env_logger = { workspace = true }
# `total_listeners()` (how tests observe that a waiter parked) is std-gated.
Expand Down
3 changes: 2 additions & 1 deletion storages/chat-store/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ search = []

[dependencies]
buffa = { workspace = true }
chrono = { workspace = true, features = ["std", "clock"] }
# `now` implies `std` and skips the local-timezone backends; only `Utc` is used.
chrono = { workspace = true, features = ["now"] }
diesel = { workspace = true }
diesel_migrations = { workspace = true }
log = { workspace = true }
Expand Down
1 change: 0 additions & 1 deletion storages/sqlite-storage/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ sha2 = { workspace = true }

[dev-dependencies]
portable-atomic = { workspace = true }
tokio = { workspace = true, features = ["sync", "rt", "time", "macros"] }

[lints]
workspace = true
5 changes: 3 additions & 2 deletions wacore/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ compact_str = { workspace = true }
ctr = { workspace = true }
dhat = { version = "0.3", optional = true }
event-listener = { workspace = true }
flate2 = { workspace = true }
futures = { workspace = true, features = ["std"] }
getrandom = { workspace = true, optional = true }
hashbrown = { workspace = true }
Expand All @@ -85,7 +84,6 @@ smoothutf8 = { workspace = true }
subtle = { workspace = true }
thiserror = { workspace = true }
tracing = { workspace = true, optional = true }
typed-builder = "0.23"
wacore-appstate = { workspace = true }
wacore-binary = { workspace = true, features = ["serde"] }
zeroize = { workspace = true }
Expand All @@ -101,6 +99,9 @@ sha2 = { workspace = true }

[dev-dependencies]
divan = { workspace = true }
# Compression only: the runtime inflates through `wacore_binary::zlib_pool`
# (zlib-rs directly), so flate2 stays out of the release dependency set.
flate2 = { workspace = true }
futures = { workspace = true, features = ["executor", "thread-pool"] }
tokio = { workspace = true, features = ["macros", "rt", "time"] }

Expand Down
1 change: 0 additions & 1 deletion wacore/appstate/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ simd = ["wacore-binary/simd"]
[dependencies]
anyhow = { workspace = true }
buffa = { workspace = true }
bytemuck = { workspace = true }
hex = { workspace = true }
hkdf = { workspace = true }
hmac = { workspace = true }
Expand Down
28 changes: 12 additions & 16 deletions wacore/appstate/src/lthash.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,15 @@ fn perform_pointwise_with_overflow(base: &mut [u8], input: &[u8], subtract: bool
let (input_chunks, input_rem) = input_remaining.as_chunks::<16>();

for (base_chunk, input_chunk) in base_chunks.iter_mut().zip(input_chunks) {
let mut base_arr: [u16; 8] = bytemuck::cast(*base_chunk);
let mut input_arr: [u16; 8] = bytemuck::cast(*input_chunk);
if cfg!(target_endian = "big") {
for v in &mut base_arr {
*v = v.swap_bytes();
}
for v in &mut input_arr {
*v = v.swap_bytes();
}
}
// `from_le_bytes` per lane states the wire endianness directly, so
// the same code is correct on either host; on little-endian it
// lowers to the plain 16-byte load a transmute would have emitted.
let base_arr: [u16; 8] = core::array::from_fn(|i| {
u16::from_le_bytes([base_chunk[2 * i], base_chunk[2 * i + 1]])
});
let input_arr: [u16; 8] = core::array::from_fn(|i| {
u16::from_le_bytes([input_chunk[2 * i], input_chunk[2 * i + 1]])
});
let base_simd = u16x8::from_array(base_arr);
let input_simd = u16x8::from_array(input_arr);

Expand All @@ -97,13 +96,10 @@ fn perform_pointwise_with_overflow(base: &mut [u8], input: &[u8], subtract: bool
base_simd + input_simd
};

let mut out = result_simd.to_array();
if cfg!(target_endian = "big") {
for v in &mut out {
*v = v.swap_bytes();
}
let out = result_simd.to_array();
for (base_pair, lane) in base_chunk.as_chunks_mut::<2>().0.iter_mut().zip(out) {
*base_pair = lane.to_le_bytes();
}
*base_chunk = bytemuck::cast(out);
}

base_remaining = base_rem;
Expand Down
4 changes: 0 additions & 4 deletions wacore/libsignal/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ legacy-session-interop = []

[dependencies]
aes = { workspace = true }
arrayref = "0.3.9"
async-lock = { workspace = true }
async-trait = { workspace = true }
buffa = { workspace = true }
Expand All @@ -24,8 +23,6 @@ cbc = { workspace = true }
chrono = { workspace = true, features = ["now"] }
ctr = { workspace = true }
curve25519-dalek = "5.0.0"
derive_more = { version = "2.1.1", features = ["from", "into", "try_from"] }
displaydoc = "0.2.7"
ghash = "0.6.0"
hex = { workspace = true }
hkdf = { workspace = true }
Expand All @@ -38,7 +35,6 @@ sha1 = { workspace = true }
sha2 = { workspace = true }
subtle = { workspace = true }
thiserror = { workspace = true }
uuid = { workspace = true }
wacore-derive = { workspace = true }
waproto = { workspace = true }
x25519-dalek = { version = "3.0.0", features = ["static_secrets"] }
Expand Down
Loading
Loading