-
-
Notifications
You must be signed in to change notification settings - Fork 124
fix(ci): get the MSRV job and cargo-deny green again #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e697dc6
77d0eef
d053361
86716c4
abe1262
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -429,7 +429,15 @@ jobs: | |
| # Pinned rather than `@stable`: this version is the workspace MSRV | ||
| # (`rust-version` in the root Cargo.toml). To raise the floor, bump both | ||
| # together — a floating `stable` would silently let the declared MSRV rot. | ||
| - uses: dtolnay/rust-toolchain@1.100.0 | ||
| # | ||
| # And it is not Dependabot's to raise. This ref is a Rust version, not a | ||
| # release of the action, so the updater bumps it by comparing numbers and | ||
| # has no way to know the toolchain has to exist and has to match the | ||
| # declared floor. It once moved this to 1.100.0 — numerically the largest | ||
| # ref, a Rust release that does not exist — and every pull request in the | ||
| # repository failed at `rustup`, before a line was compiled. The | ||
| # `dependabot.yml` entry beside this one is what keeps the pin ours. | ||
| - uses: dtolnay/rust-toolchain@1.94.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔒 Security & Privacy | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- applicable repository conventions ---'
find /tmp/coderabbit-repo-knowledge/oxidezap-whatsapp-rust-0f309e03 -type f -name '*.md' -print
printf '%s\n' '--- workflow context ---'
sed -n '420,455p' .github/workflows/main.yml
printf '%s\n' '--- dependabot context ---'
sed -n '1,220p' .github/dependabot.yml
printf '%s\n' '--- action references ---'
rg -n -C 2 'dtolnay/rust-toolchain|1\.94\.1|MSRV|unpinned-uses' .github Cargo.tomlRepository: oxidezap/whatsapp-rust Length of output: 17052 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- workflow conventions and learnings ---'
cat /tmp/coderabbit-repo-knowledge/oxidezap-whatsapp-rust-0f309e03/conventions/repo-wide.md
printf '%s\n' '--- GitHub workflow learning ---'
cat /tmp/coderabbit-repo-knowledge/oxidezap-whatsapp-rust-0f309e03/learnings/github-workflows.md
printf '%s\n' '--- upstream README references ---'
curl -fsSL https://raw.githubusercontent.com/dtolnay/rust-toolchain/master/README.md |
rg -n -C 3 'rust-toolchain@|toolchain:|1\.94\.1|version'
printf '%s\n' '--- upstream ref resolution ---'
for ref in '1.94.1' 'master'; do
printf '%s\n' "REF $ref"
curl -fsSL "https://api.github.com/repos/dtolnay/rust-toolchain/git/ref/$([ "$ref" = master ] && printf heads || printf tags)/$ref" |
jq '{ref: .ref, object: .object}'
doneRepository: oxidezap/whatsapp-rust Length of output: 5691 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- exact upstream ref lookup ---'
git ls-remote https://github.com/dtolnay/rust-toolchain.git \
'refs/heads/1.94.1' 'refs/tags/1.94.1' 'refs/tags/1.94.1^{}' \
'refs/heads/master' 'refs/tags/master'Repository: oxidezap/whatsapp-rust Length of output: 312 Security Misconfiguration (CWE-494): Download of Code Without Integrity Check Reachability: External · Exploitability: Difficult Pin the action code separately from the Rust toolchain.
🧰 Tools🪛 zizmor (1.29.0)[error] 440-440: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) [info] 440-440: action functionality is already included by the runner (superfluous-actions): use (superfluous-actions) 🤖 Prompt for AI AgentsSources: MCP tools, Linters/SAST tools |
||
| # The pre-built nextest binary is toolchain-independent — it drives this | ||
| # MSRV cargo the same way it drives the nightly one. | ||
| - name: Install protoc and cargo-nextest | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new comment repeats the Dependabot exclusion rationale already added in
.github/dependabot.yml. Keeping the decision rationale in two places increases maintenance work and allows the copies to provide conflicting guidance when the MSRV policy changes.Context Used: CLAUDE.md (source)
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!