Skip to content

perf: binary #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 4 commits into from
Feb 11, 2026
Merged

perf: binary #279

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a3d837
perf: binary
jlucaso1 Feb 11, 2026
53b3fa8
perf: binary
jlucaso1 Feb 11, 2026
c2bc958
perf: binary 2
jlucaso1 Feb 11, 2026
2c5ca20
Review comments
jlucaso1 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion wacore/binary/src/decoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,11 @@ impl<'a> Decoder<'a> {
unpacked_bytes.pop();
}

String::from_utf8(unpacked_bytes).map_err(|e| BinaryError::InvalidUtf8(e.utf8_error()))
// SAFETY: unpacked bytes are built exclusively from protocol lookup tables:
// - HEX_8 produces ASCII '0'..'9' and 'A'..'F'
// - NIBBLE_8 produces ASCII '0'..'9', '-', '.', or '\0' padding
// All generated bytes are valid UTF-8 scalar values.
Ok(unsafe { String::from_utf8_unchecked(unpacked_bytes) })
}

fn unpack_byte(tag: u8, value: u8) -> Result<char> {
Expand Down
Loading