refactor: codebase quality audit — safety, tests, DRY, dep hygiene - #404

Merged

jlucaso1 merged 12 commits into

mainfrom

refactor/codebase-quality-audit

Mar 21, 2026

Commits on Mar 21, 2026

fix: quick safety and cleanup fixes
jlucaso1
committed
f7c39f4
refactor: standardize feature struct Client types + document MAC TODO
jlucaso1
committed
f7f90f2
test: add comprehensive crypto test coverage for hash.rs and aes_cbc.rs
jlucaso1
committed
6d727bd
refactor: simplify error handling patterns in upload.rs and messages.rs
jlucaso1
committed
fe9bbc7
chore: remove unused itertools dep + move shared deps to workspace
jlucaso1
committed
9edba90
fix: address review feedback — poison handling consistency + doc fixes
jlucaso1
committed
02d309e
fix: add semaphore generation counter to prevent stale-Arc race
jlucaso1
committed
501a2a7
feat: implement SetAdvSecretKey + re-enable HMAC verification in pairing
jlucaso1
committed
bd075ef
fix: revert HMAC verification — QR pairing doesn't rotate adv_secret_key
jlucaso1
committed
7d2cfdd
fix: use symbol reference instead of line number in pair.rs TODO
jlucaso1
committed
c3c126c
fix: add post-acquire generation recheck to close TOCTOU window
jlucaso1
committed
74b0bd1
fix: correct semaphore generation ordering + extract helper
jlucaso1
committed
f376414