fix: self-DM/sibling decryption deadlock (retry shape + session recovery + peer pkmsg identity) - #635

Merged

jlucaso1 merged 29 commits into

mainfrom

fix/dm-retry-stanza-format

May 21, 2026

Commits on May 19, 2026

Commits on May 20, 2026

fix(retry): force session recreate on no-keys retry receipts (whatsmeow parity)
jlucaso1
committed
c31f06d
review: harden retry tests + recreate-on-error semantics
jlucaso1
committed
d56323a
test(retry): pin recipient verbatim forwarding from receipt attr
jlucaso1
committed
35f94cd
fix(pdo): address peer messages to LID when LID-migrated (WA Web parity)
jlucaso1
committed
d6b4612
Revert "fix(pdo): address peer messages to LID when LID-migrated (WA Web parity)"
jlucaso1
committed
47db358
fix(lid-migration): PN session wins on conflict (whatsmeow parity)
jlucaso1
committed
712f5e4
fix(libsignal): transactional decrypt — failed MAC must not advance chain
jlucaso1
committed
bf691f5
fix(message): migrate PN session on inbound BadMac/InvalidMessage

jlucaso1
and
codex
committed
53c98e0
fix(pdo): address peer messages to LID when LID-migrated (whatsmeow parity)
jlucaso1
committed
234b922
fix(send): include <meta>+<device-identity> on peer pkmsg (whatsmeow parity)
jlucaso1
committed
8a54365
test(send): regression tests for peer pkmsg stanza layout
jlucaso1
committed
ac0d1c1
review: address PR #635 comments + fix CI
jlucaso1
committed
27be97b
fix(send): refuse to ship peer pkmsg without <device-identity>
jlucaso1
committed
5a70089
perf(libsignal): snapshot only mutable decrypt fields + scrub PII
jlucaso1
committed
0a59219
review: address Codex+CodeRabbit findings
jlucaso1
committed
676e07c
review: serialize migration with session_locks + fix throttle expiry
jlucaso1
committed
7ad35e9
test(retry): exercise throttle-expiry branch via injectable clock
jlucaso1
committed
c643592
fix(lid-migration): skip re-acquiring LID lock that decrypt caller holds
jlucaso1
committed
39f299f
refactor(lid-migration): lock dance in the function, not its API
jlucaso1
committed
668c385
review: address all Codex devil's-advocate findings
jlucaso1
committed
c5f9683
fix(send): restore checked-out session in pkmsg pre-flight (CodeRabbit P2)
jlucaso1
committed
24c6057
review: conservative pre-flight + dedup duplicate phone batches (CodeRabbit)
jlucaso1
committed
c3edc17

Navigation Menu

Uh oh!

Uh oh!

fix: self-DM/sibling decryption deadlock (retry shape + session recovery + peer pkmsg identity) - #635

fix: self-DM/sibling decryption deadlock (retry shape + session recovery + peer pkmsg identity)#635
jlucaso1 merged 29 commits into
mainfrom
fix/dm-retry-stanza-format

Commits on May 19, 2026

fix(send): align DM retry stanza with WA Web (479 SmaxInvalid)

fix: CI feedback — drop duplicated #[allow] and trim retry shape comments

test(e2e): ignore retry_dm_multidevice — mock server doesn't route the

fix(retry): forward receipt's recipient verbatim (WA Web parity)

Commits on May 20, 2026

fix(retry): force session recreate on no-keys retry receipts (whatsmeow parity)

review: harden retry tests + recreate-on-error semantics

test(retry): pin recipient verbatim forwarding from receipt attr

fix(pdo): address peer messages to LID when LID-migrated (WA Web parity)

Revert "fix(pdo): address peer messages to LID when LID-migrated (WA Web parity)"

fix(lid-migration): PN session wins on conflict (whatsmeow parity)

fix(libsignal): transactional decrypt — failed MAC must not advance chain

fix(message): migrate PN session on inbound BadMac/InvalidMessage

fix(pdo): address peer messages to LID when LID-migrated (whatsmeow parity)

fix(send): include <meta>+<device-identity> on peer pkmsg (whatsmeow parity)

test(send): regression tests for peer pkmsg stanza layout

review: address PR #635 comments + fix CI

fix(send): refuse to ship peer pkmsg without <device-identity>

perf(libsignal): snapshot only mutable decrypt fields + scrub PII

review: address Codex+CodeRabbit findings

review: serialize migration with session_locks + fix throttle expiry

test(retry): exercise throttle-expiry branch via injectable clock

fix(lid-migration): skip re-acquiring LID lock that decrypt caller holds

refactor(lid-migration): lock dance in the function, not its API

review: address all Codex devil's-advocate findings

fix(send): restore checked-out session in pkmsg pre-flight (CodeRabbit P2)

review: conservative pre-flight + dedup duplicate phone batches (CodeRabbit)

Commits on May 21, 2026

fix(send): close pkmsg pre-flight gap in prepare_group_retry_stanza

nit: fix step numbering + doc-comment on inner test helper

feat(example): auto-pair benchmark example with mock server