Skip to content

fix(send): fail DM send when every per-device encrypt fails #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 2 commits into from
May 28, 2026
Merged

fix(send): fail DM send when every per-device encrypt fails #652

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1a7584
fix(send): fail DM send when every per-device encrypt fails
jlucaso1 May 28, 2026
55a06e8
fix(send): gate all-fail error on attempted devices, not total
jlucaso1 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions wacore/src/send.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,15 @@ pub async fn prepare_dm_stanza<
includes_prekey_message = includes_prekey_message || result.includes_prekey_message;
}

// All per-device encrypts failed: an empty <participants> would silently
// drop the message. WA Web's encryptAndSendUserMsg rejects here too.
let attempted_devices = recipient_devices.len() + own_other_devices.len();
if participant_nodes.is_empty() && attempted_devices > 0 {
return Err(anyhow!(
"encryption failed for all {attempted_devices} recipient device(s)"
));
}

let mut message_content_nodes = vec![
NodeBuilder::new("participants")
.children(participant_nodes)
Expand Down
Loading