feat(newsletter): mute/unmute channel notifications - #757
Merged
Conversation
Adds Newsletter::set_follower_mute and set_admin_mute, mirroring WA Web's
WAWebNewsletterUpdateUserSettingJob. Both go through the vendored
update_newsletter_user_setting MEX mutation with the wire shape
{ input: { newsletter_id, type, value } }, where type is
MUTE_FOLLOWER_ACTIVITY / MUTE_ADMIN_ACTIVITY and value is ON/OFF. The
mute-expiration WA Web tracks is local DB state, not on the wire, so the
public API is a simple bool.
The generated op's input type is an opaque string, so the structured input
object is passed via mex_request!'s raw-variables form. Verified against
docs/captured-js/WAWeb/Newsletter/UpdateUserSettingJob.js and
Mex/UpdateNewsletterUserSetting*.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR extends the Newsletter feature with mute/unmute operations for follower-activity and admin-activity notifications. Two public methods execute the ChangesNewsletter notification mute
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Benchmark Results67 unchanged benchmark(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the features-04 gap.
There was no way to mute a newsletter/channel — WA Web supports silencing follower-activity (and, for owners/admins, admin-activity) notifications, but the library exposed nothing.
Adds
Newsletter::set_follower_mute(jid, muted)andNewsletter::set_admin_mute(jid, muted), both going through the vendoredupdate_newsletter_user_settingMEX mutation. The wire shape matches WA Web exactly:{ input: { newsletter_id, type, value } }wheretypeisMUTE_FOLLOWER_ACTIVITY/MUTE_ADMIN_ACTIVITYandvalueisON/OFF. WA Web's mute-expiration is local DB state (never on the wire), so the public API is a simplebool.The generated op's
inputis an opaque string (relay-compiled, the input object type isn't expanded), so the structured object is passed viamex_request!'s raw-variables form rather than the typedVariables { input: String }.Test:
mute_variables_match_wa_web_shapelocks the variables shape (newsletter_id / type / ON-OFF) so a wire-format regression is caught without a live server.Verified against
docs/captured-js/WAWeb/Newsletter/UpdateUserSettingJob.js(the{ newsletter_id, type, value }call) andMex/UpdateNewsletterUserSetting.js+UpdateNewsletterUserSettingJobMutation.graphql.js(doc_id 31938993655691868, matches the vendored op).