Skip to content

perf(wacore): drop the proto PartialEq anchor from the skdm-only check #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 1 commit into from
Jun 11, 2026
Merged

perf(wacore): drop the proto PartialEq anchor from the skdm-only check #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion wacore/src/messages.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,9 @@ pub fn is_sender_key_distribution_only(msg: &mut wa::Message) -> bool {
let fast = msg.fast_ratchet_key_sender_key_distribution_message.take();
let ctx = msg.message_context_info.take();

let only = *msg == wa::Message::default();
// Same predicate as `== Message::default()` (proto2 fields only encode
// when set), without anchoring prost's derived PartialEq tree.
let only = waproto::codec::message_encoded_len(msg) == 0;

msg.sender_key_distribution_message = skdm;
msg.fast_ratchet_key_sender_key_distribution_message = fast;
Expand Down
Loading