Skip to content

perf(signal): flush the signal cache without holding the device read-lock #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlucaso1 merged 2 commits into from
Jun 18, 2026
Merged

perf(signal): flush the signal cache without holding the device read-lock #888

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496da5a
perf(signal): flush the signal cache without holding the device read-…
claude Jun 18, 2026
30d88f6
docs(signal): trim the flush comment to the why per AGENTS.md
claude Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/client/adapters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,16 @@ impl Client {
/// Flush the in-memory signal cache to the database backend.
/// Called after each message is decrypted or after encryption operations.
pub(crate) async fn flush_signal_cache(&self) -> Result<(), anyhow::Error> {
let device = self.persistence_manager.get_device_arc().await;
let device_guard = device.read().await;
// Clone the backend Arc out of the snapshot and hold no device lock across
// the flush: this batched SQLite write runs per message, and a device guard
// held for its duration would block every concurrent Device write.
Comment thread
jlucaso1 marked this conversation as resolved.
Outdated
let backend = self
.persistence_manager
.get_device_snapshot()
.backend
.clone();
self.signal_cache
.flush(&*device_guard.backend)
.flush(&*backend)
.await
.map_err(|e| anyhow::anyhow!("Failed to flush signal cache: {e}"))
}
Expand Down
Loading