This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Open
Conversation
Owner
|
There are some code paths that require looking up easyXDM on the global object (SameOriginTransport comes to mind) - could you review the implications for this, if it's acceptable, and whether some docs should be added for this? |
Author
|
Thanks. Can you please provide more information about transports using easyXDM on the global object? Do they use the namespace if .noConflict() was called? Maybe if we're in AMD environment, we can also set the namespace and use that reference inside of the components that need to access the easyXDM object. (Or move to an event-based architecture? But i doubt to have the time to contribute for that.) |
4e46f32 to
2769b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds AMD support reverting to variable in global scope if not on AMD environment.