Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Add AMD support#221

Open
alejandroiglesias wants to merge 1 commit intooyvindkinsey:masterfrom
alejandroiglesias:amd
Open

Add AMD support#221
alejandroiglesias wants to merge 1 commit intooyvindkinsey:masterfrom
alejandroiglesias:amd

Conversation

@alejandroiglesias
Copy link

This adds AMD support reverting to variable in global scope if not on AMD environment.

@oyvindkinsey
Copy link
Owner

There are some code paths that require looking up easyXDM on the global object (SameOriginTransport comes to mind) - could you review the implications for this, if it's acceptable, and whether some docs should be added for this?

@alejandroiglesias
Copy link
Author

Thanks. Can you please provide more information about transports using easyXDM on the global object? Do they use the namespace if .noConflict() was called? Maybe if we're in AMD environment, we can also set the namespace and use that reference inside of the components that need to access the easyXDM object. (Or move to an event-based architecture? But i doubt to have the time to contribute for that.)

@oyvindkinsey oyvindkinsey force-pushed the master branch 3 times, most recently from 4e46f32 to 2769b63 Compare April 8, 2019 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants