Refine interface of Correlator e/g objects#124
Closed
cerminar wants to merge 4 commits intop2l1pfp:L1PF_12_5_Xfrom
Closed
Refine interface of Correlator e/g objects#124cerminar wants to merge 4 commits intop2l1pfp:L1PF_12_5_Xfrom
cerminar wants to merge 4 commits intop2l1pfp:L1PF_12_5_Xfrom
Conversation
cerminar
force-pushed
the
eg_refine_interface_v0
branch
from
b3d5232 to
d27a578
Compare
cerminar
force-pushed
the
eg_refine_interface_v0
branch
from
5f4b728 to
634f1b4
Compare
…idate and cleanup TkElectron interface
…n pv-based isolation. Set charge of TkElectrons
cerminar
force-pushed
the
eg_refine_interface_v0
branch
from
634f1b4 to
60dbc4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR addresses several issues with the interface of
TkElectronandTkEmobjects:Egammastandaole objects since they are not the actual ancestors due to architectural choice in L1T hardware. The ref is replaced by aedm::Ptrto the calorimeter primitive (different in barrel and endcap).NOTE: backward compatibility is maintained via IO rule in the reflex dictionary.
PR validation:
Succesfully tested reading files produced with previous versions of the object data formats.