Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve ingress_port when re-parsing I2E clones. #1175

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Preserve ingress_port when re-parsing I2E clones. #1175

merged 1 commit into from
Jan 21, 2023

Conversation

smolkaj
Copy link
Member

@smolkaj smolkaj commented Jan 20, 2023

This is a partial fix for #795.

@antoninbas @jafingerhut

@smolkaj smolkaj mentioned this pull request Jan 20, 2023
Open
antoninbas
antoninbas approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit 6ec3ef8 into p4lang:main Jan 21, 2023
jafingerhut
jafingerhut reviewed Jan 21, 2023
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut left review comments

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smolkaj @jafingerhut @antoninbas