Skip to content

ci: add CI workflow, dependabot, and ESLint contributor rules#116

Merged
florintimbuc merged 6 commits intopablodelucca:devfrom
florintimbuc:ci/enforce-code-quality
Mar 13, 2026
Merged

ci: add CI workflow, dependabot, and ESLint contributor rules#116
florintimbuc merged 6 commits intopablodelucca:devfrom
florintimbuc:ci/enforce-code-quality

Conversation

@florintimbuc
Copy link
Collaborator

@florintimbuc florintimbuc commented Mar 12, 2026

Summary

  • Add CI workflow (.github/workflows/ci.yml) — type check, lint, format, build, security audit
  • Add Dependabot config (.github/dependabot.yml) for automated dependency updates
  • Replace scripts/check-contributors-rules.mjs with ESLint custom rules (eslint-rules/pixel-agents-rules.mjs)
  • Disable false-positive react-hooks rules for imperative game-state pattern

Closes #112

Design

  • Foundational steps (checkout, node setup, installs) fail fast
  • Validation steps (type check, lint, format, build) use continue-on-error: true with dependency guards — all run even if one fails
  • Audit steps are advisory only — reported in step summary but don't block PRs
  • Step summary table shows PASS/FAIL for every check
  • Contributors policy checks (centralized colors, pixel-font, pixel-shadow) now run as ESLint warn rules within existing lint steps — no separate CI step needed
  • react-hooks/immutability, react-hooks/refs, react-hooks/set-state-in-effect disabled (false positives on imperative OfficeState/EditorState pattern)

Attribution

This PR builds on CI work from community contributors:

Impact on open PRs

Test plan

  • CI runs on this PR itself (self-testing)
  • Step summary table renders correctly
  • ESLint rules fire as warnings (not errors) for existing violations
  • Audit steps report but don't block

@florintimbuc florintimbuc changed the base branch from main to dev March 13, 2026 20:53
@pablodelucca pablodelucca self-requested a review March 13, 2026 21:17
@florintimbuc florintimbuc merged commit 8797b6a into pablodelucca:dev Mar 13, 2026
@florintimbuc florintimbuc deleted the ci/enforce-code-quality branch March 13, 2026 21:18
florintimbuc added a commit that referenced this pull request Mar 14, 2026
* ci: add CI workflow, dependabot, and ESLint contributor rules

* Update CONTRIBUTING

* ci: add CI workflow, dependabot, and ESLint contributor rules

* Update CONTRIBUTING
This was referenced Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants