Skip to content

Resolve issues #9 and #10 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremylong wants to merge 10 commits into from
Closed

Resolve issues #9 and #10 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
539abd9
updated test cases
jeremylong Jan 12, 2019
f77bfe1
updated code and tests for #9 and #10
jeremylong Jan 12, 2019
8509a13
checkstyle cleanup
jeremylong Jan 12, 2019
523cf95
snapshot 1.1.0
jeremylong Jan 12, 2019
b0d3279
add spotbugs and resolve identified issue
jeremylong Jan 12, 2019
2304696
minor performance improvement in parsing
jeremylong Jan 13, 2019
5e84ae8
added toString()
jeremylong Jan 13, 2019
a6550dc
added toString() caching
jeremylong Jan 13, 2019
a7d7271
increase branch coverage on tests
jeremylong Jan 13, 2019
8b4b7e4
correct validation of type and qualifier
jeremylong Jan 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.github.package-url</groupId>
<artifactId>packageurl-java</artifactId>
<version>1.0.1-SNAPSHOT</version>
<version>1.1.0-SNAPSHOT</version>
<packaging>jar</packaging>

<name>Package URL</name>
Expand Down Expand Up @@ -51,6 +51,8 @@
<plexus.compiler.javac.errorprone.version>2.8.5</plexus.compiler.javac.errorprone.version>
<error.prone.core.version>2.3.2</error.prone.core.version>
<jacoco.maven.plugin.version>0.8.2</jacoco.maven.plugin.version>
<spotbugs.maven.plugin.version>3.1.9</spotbugs.maven.plugin.version>
<com.github.spotbugs.version>3.1.10</com.github.spotbugs.version>
</properties>

<scm>
Expand Down Expand Up @@ -130,6 +132,27 @@
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs.maven.plugin.version}</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<dependencies>
<!-- overwrite dependency on spotbugs if you want to specify the version of spotbugs -->
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>${com.github.spotbugs.version}</version>
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/github/packageurl/MalformedPackageURLException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ public MalformedPackageURLException(String msg) {
super(msg);
}

}
}
Loading