Skip to content

fix: remove unused method indexOfUnsafeChar #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremylong merged 2 commits into from
Mar 21, 2025
Merged

fix: remove unused method indexOfUnsafeChar #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
436d58d
fix: remove unused method `indexOfUnsafeChar`
dwalluck Mar 20, 2025
8fa5b1a
Inline second argument of `indexOfFirstPercentChar`
dwalluck Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/main/java/com/github/packageurl/PackageURL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,20 +589,13 @@ private static String toLowerCase(String s) {
return new String(chars);
}

private static int indexOfPercentChar(final byte[] bytes, final int start) {
return IntStream.range(start, bytes.length)
private static int indexOfFirstPercentChar(final byte[] bytes) {
return IntStream.range(0, bytes.length)
.filter(i -> isPercent(bytes[i]))
.findFirst()
.orElse(-1);
}

private static int indexOfUnsafeChar(final byte[] bytes, final int start) {
return IntStream.range(start, bytes.length)
.filter(i -> shouldEncode(bytes[i]))
.findFirst()
.orElse(-1);
}

private static byte percentDecode(final byte[] bytes, final int start) {
if (start + 2 >= bytes.length) {
throw new ValidationException("Incomplete percent encoding at offset " + start + " with value '"
Expand Down Expand Up @@ -636,7 +629,7 @@ private static String percentDecode(final String source) {
}

byte[] bytes = source.getBytes(StandardCharsets.UTF_8);
int i = indexOfPercentChar(bytes, 0);
int i = indexOfFirstPercentChar(bytes);

if (i == -1) {
return source;
Expand Down