feat: add a small benchmark for percent encoding decoding #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a small benchmark for percent encoding/decoding algorithms. You can run it with: ``` mvn -Pbenchmark ``` To pass arguments to JMH use `-Djmh.args="<arguments>"`.
Contributor
|
But, what do we compare it to? Another existing implementation? Commons Codec will be significantly faster since it operates on |
Collaborator
|
the use for this benchmark in comparing versions - if we update the encoding again. |
jeremylong
reviewed
Mar 22, 2025
Co-authored-by: Jeremy Long <[email protected]>
jeremylong
approved these changes
Mar 22, 2025
Contributor
Author
Exactly, the purpose of the benchmark is to check which modifications of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a small benchmark for percent encoding/decoding algorithms. You can run it with:
To pass arguments to JMH use
-Djmh.args="<arguments>".