feat: Improve encoding/decoding performance for ASCII strings #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in the benchmark initialization and adds a `toLowerCase` benchmark.
The benchmark **must** be initialized in a `@Setup` method, otherwise `nonAsciiProb` will always be `0.0`.
Since strings that don't require **any** percent encoding are in practice the rule, the encoding/decoding code should be optimized for this case.
ppkarwasz
changed the title
Contributor
Author
Benchmark before
Benchmark after
|
…s' into feat/percent-performance
jeremylong
merged commit ae666d9
into
package-url:scratch/refactor-stringutils
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in practice most Package URLs don't have any percent encoded characters, this PR optimizes the
percentEncode/percentDecodemethods by:isUnreserved, since profiling shows that this is the most important method for the performance ofpercentEncode.