Migrate to schema 4.0.0 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: Common - Lift all checks to v4.0.0 schema (2.0, 3.0.0 are not supported) - re-order attributes and methods more logically in `TestContainer` - split some package and library related test methods to reduce spaghetti - enforce https:// protocol - support for file:// protocol (convert to filesystem path to open includes) - expect files on given location (no more automatic upward traversals) Repositories - rename "dependencies" keys to "libraries" - "packages" and "libraries" are optional - recursive "includes" are supported - allow included repositories with ascii names other than 0-9.json, a.json, ... Packages Libraries - "load_order" is removed - case-sensitive library name duplicate checks -> libaries are imported, python import machinary is case-sensitive -> support e.g. Jinja2 package vs. jinja2 library to co-exist Releases - "asset", "python_versions" is added - "sublime_text" release key is optional
1. advice removal of optional `"sublime_text": "*"` 2. advice removal of obsolete version checks targeting builds before 3143 3. advice removal of incompatible releases, which are always ignored by PC4.
Advice removal of optional `"platforms": "*"` or `"platforms": ["*"]` as those don't specify any restrictions. PC4 implicitly uses `"*"` if key is absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Changes include:
Common
TestContainerRepositories
Libraries
Releases
Warning
Test code in this branch does not support schema version 2.0 or 3.0.0
and is thus not backward compatible!
It primarily targets testing sublimehq/package_control_channel/four-point-oh