ENG-1059: Throw errors #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lin-brian-l
commented
Sep 13, 2024
Comment on lines
-24
to
-25
| typings/types.d.ts | ||
| typings/promiseBasedTypes.d.ts No newline at end of file |
There was a problem hiding this comment.
Annoyingly, TSLint was failing because these files weren't committed to the repo 🙃.
| await this.runTests(test); | ||
| } catch (e) { | ||
| output.error(e.stack); | ||
| throw e; |
There was a problem hiding this comment.
This is the actual fix, which causes the run-rerun command to properly set the exit code to 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
This PR causes failures from run-rerun to be thrown. After some testing, the existing code in run-rerun will exit with an error code of 1 if the last-executed test fails but I wasn't able to pinpoint why exit code 1 wasn't being thrown if the first test (or any other test than the last one) failed.
Note: I've also made a PR on the CodeceptJS repo. However, I made a separate branch because I didn't want to commit the typing files in the branch I have for that PR.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)