MGMT-191 Submission #161
Open
MGMT-191 Submission #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per IMS AGS v2.0 specification, adds support for optional 'submission' field that can include 'startedAt' and 'submittedAt' timestamps. Maintains backward compatibility with Canvas-specific submission extension. Implements #149
|
Hello! I was just looking at this today. Is there any reason this can't be merged? Thanks! |
|
@JonathanGawrych I haven't had a chance to manually test it and confirm it works as expected. If you can test this branch out and verify it works, I'm happy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As per IMS AGS v2.0 specification, adds support for optional 'submission' field that can include 'startedAt' and 'submittedAt' timestamps.
Maintains backward compatibility with Canvas-specific submission extension.
Implements #149
Testing
We should probably do some manual testing on this one. (See what happens, for example, if we remove the call for the canvasExtension in our codebase, or test it out with other LMSes).
composer testbefore opening this PRcomposer lint-fixbefore opening this PR