beeai/pyproject.yml: require beeai-framework<=0.1.41 #162
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly pins the beeai-framework dependency in pyproject.toml to avoid a breaking API change. The change is appropriate and necessary. My review includes one comment on the change, suggesting that a similar version pin should be applied in beeai/Containerfile.tests to ensure the test environment's stability and prevent potential build failures.
beeai-framework 0.1.42 introduces an API break (i-am-bee/beeai-framework#1013) Our main containerfile uses 0.1.40+patches, but for the development environment and tests, we were just pulling the latest.
owtaylor
force-pushed
the
beeai-framework-lt-0.1.42
branch
from
aa2cebf to
a2db8b4
Compare
|
@nforro already rebased to 1.43: https://github.com/packit/ai-workflows/pull/164/files we have missed this PR, sorry Owen! |
Yes, but I didn't update the version in these two files 🤦 so this is still valid, just the version number should be |
Rebasing to 0.1.43 is even better! I guess the question is whether we want to pin the version of beeai-framework in Containerfile.tests and pyproject.toml. When I first created the pyproject.toml the main Containerfile was pinned to +patches - since there was no (easy) way to apply the patches, I thought using the latest beeai-framework was better. But:
So perhaps pinning to 0.1.43 makes sense at this point. |
beeai-framework 0.1.42 introduces an API break for agent.run()
(i-am-bee/beeai-framework#1013)