Skip to content

Conversation

@owtaylor
Copy link
Collaborator

@owtaylor owtaylor commented Oct 1, 2025

We're no longer referencing this anywhere in the code for the agents.

We're no longer referencing this anywhere in the code for
the agents.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the GITLAB_USER environment variable, which is no longer in use. The changes are applied consistently across the OpenShift deployment configurations and the corresponding documentation in openshift/README.md. I have confirmed that the variable is not referenced in the agent code, so its removal is correct. This is a good cleanup that simplifies the configuration.

Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, LGTM, thanks for the cleanup!

@owtaylor owtaylor merged commit ca7cab9 into packit:main Oct 6, 2025
6 checks passed
@owtaylor owtaylor deleted the gitlab-user-removal branch October 6, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants