-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Sentry related env var in dashboard pod #576
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
6f88186
to
72d03e4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I see the PR actually requires 2 env vars, I will have a look into the SENTRY_AUTH_TOKEN. |
6c0e2a4
to
d36b1f5
Compare
Build failed. ✔️ pre-commit SUCCESS in 1m 51s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't DSN enough? 👀
@mfocko |
Correct me if I'm wrong, but based on the docs:
I understand that this token needs to be present during the build, not while deployed, so this is something that should be exposed in the dashboard repo and for the GH Action (that actually builds the images). Based on the docs from the first link, I have a feeling that it should work correctly by matching the commit SHA to the image. I'm not very happy about having the org-wide Sentry token present in the deployment, if (hopefully) there's no need for it. (Based on the discussion with @lbarcziova) |
Correct, should only be needed during build |
d36b1f5
to
bdadac6
Compare
thanks @Venefilyn for confirmation! Then I updated this PR only adding the VITE_SENTRY_DSN and the SENTRY_AUTH_TOKEN will be added in the dashboard repo. |
Build failed. ✔️ pre-commit SUCCESS in 1m 42s |
Related to packit/dashboard#410