chore: use k8s_apply=true by default #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 01s |
• Summary Initially I wanted to do ‹k8s_apply=false› for postgres, and key-value databases (such as Redis, Redict, or Valkey), because deploying on prod with ‹k8s_apply=true› caused redeployment of the postgres which caused a small outage (~5 minutes). Right now when I tried to redeploy stage multiple times in a row, none of the deployed services got redeployed, hence I come to the conclusion that there were some changes on the production deployment that were applied back then. • Context from packit#360 · What it actually does? In the simple terms, it makes sure that the definition that is to be deployed matches the one that is already deployed. The difference has already manifested few times, e.g., when @majamassarini was adjusting the `/dev/shm` for the postgres deployment (bedef20), the change did not get deployed. · Why some tasks already use it (e.g., Redis/Redict, Flower secret) and others not? not sure · Would it make sense to default to ‹apply=true›? Yes, but at the same time, applying meaningless changes to critical services, e.g., postgres or Redis/Redict/Valkey, can cause smaller outages. Fixes packit#360 Signed-off-by: Matej Focko <[email protected]>
mfocko
force-pushed
the
chore/k8s-apply
branch
from
67187fa to
27d3abd
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 40s |
lbarcziova
approved these changes
Oct 2, 2024
ofc we can, affects manual redeployments though, so not sure who remembers about it by the time we need to touch it manually :D even the TLS certs from Monday were without redeployment (I scaled stage, and Franta moved production, rebuilt images loaded new certs on automatic redeployment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Summary
Initially I wanted to do ‹k8s_apply=false› for postgres, and key-value
databases (such as Redis, Redict, or Valkey), because deploying on prod
with ‹k8s_apply=true› caused redeployment of the postgres which caused
a small outage (~5 minutes).
Right now when I tried to redeploy stage multiple times in a row, none of
the deployed services got redeployed, hence I come to the conclusion that
there were some changes on the production deployment that were applied
back then.
• Context from #360
· What it actually does?
· Why some tasks already use it (e.g., Redis/Redict, Flower secret) and
others not?
· Would it make sense to default to ‹apply=true›?
Fixes #360