Fix Specfile.update_value() #280
Conversation
Macro definitions and tags that are in a false branch of a condition can not be considered modifiable, because modyfing their values would have no effect on the value being updated. Signed-off-by: Nikola Forró <[email protected]>
There can be multiple tags or macro definitions with the same name in a spec file. In such case, a name is not unique-enough key to search for the corresponding object, a position is needed as well. Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 22s |
|
Good point, let me extend test_update_tag. |
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 22s |
|
It turns out RPM version in EL8 doesn't support the I'm going to mark the |
|
@lbarcziova Do you think I should also adjust the code to raise an exception when the evaluation doesn't work? The current implementation makes it silently pass, with every condition expression evaluated as |
Signed-off-by: Nikola Forró <[email protected]>
Actually, to stick with the current logic, it makes more sense to just resolve it as |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 31s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 17m 43s |
Related to packit/packit#2033.