Make modifiable entity groups greedy #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 23s |
lachmanfrantisek
approved these changes
Sep 19, 2023
This effectively makes the first group most greedy, rather than the
last. So, with the following in a spec file:
```
%global apiver 2.15
%global patchver 3
Version: %{apiver}.%{patchver}
```
calling `spec.update_tag("Version", "2.16.0")`, the `apiver` macro
gets assigned the bigger portion of the version string, resulting in:
```
%global apiver 2.16
%global patchver 0
```
rather than:
```
%global apiver 2
%global patchver 16.0
```
There are cases (in Fedora spec files) where the previous logic
makes more sense, but only a handful of them, and none of them
using packit.
With the current implementation, it's one or the other, and I believe
this makes more sense.
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 28s |
lachmanfrantisek
approved these changes
Sep 19, 2023
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 32s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively makes the first group most greedy, rather than the last. So, with the following in a spec file:
calling
spec.update_tag("Version", "2.16.0"), theapivermacro gets assigned the bigger portion of the version string, resulting in:rather than:
There are cases (in Fedora spec files) where the previous logic makes more sense, but only a handful of them, and none of them using packit.
With the current implementation, it's one or the other, and I believe this makes more sense.
Related to packit/packit#2033