Take validity into account when accessing tags and macro definitions by name #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 49s |
majamassarini
approved these changes
Dec 1, 2023
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 50s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327.
RELEASE NOTES BEGIN
When accessing tags or macro definitions by name, specfile now takes validity into account when looking for the best match. For example if there are two instances of
Versiontag, one in the true and one in the false branch of a condition,Specfile.versionwill always access the one that is in the true branch.RELEASE NOTES END