Recognize all macro definitions in hash-style comments #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macro definitions can be commented out by replacing '%' with '#', for example `%global debug 1` with `#global debug 1`, to avoid `Macro expanded in comment` warning. However, the same can be achieved also by escaping the '%' in the comment, i.e. `#%%global debug 1`, and even if the '%' is not escaped, it is still parseable, so we should be able to parse it as well. Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 48s |
lachmanfrantisek
approved these changes
Dec 14, 2023
lbarcziova
approved these changes
Dec 14, 2023
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 47s |
softwarefactory-project-zuul
bot
merged commit 24ef933
into
main
18 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro definitions can be commented out by replacing '%' with '#', for example
%global debug 1with#global debug 1, to avoidMacro expanded in commentwarning. However, the same can be achieved also by escaping the '%' in the comment, i.e.#%%global debug 1, and even if the '%' is not escaped, it is still parseable, so we should be able to parse it as well.