Handle trailing newline in macro definitions

[nikitych]

Fixes #360.

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/51088f7327484e5eba82fd07213c3e14

✔️ pre-commit SUCCESS in 2m 18s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 11s
✔️ specfile-tests-pip-deps SUCCESS in 1m 04s

[nforro]

Thank you for the fix!

However, I believe this is also a parsing issue. The ending newline character should be part of the body, not included in _whitespace. To make that right, the regex here should be replaced with ([^\S\n]+)$ (not to match \n characters):

specfile/specfile/macro_definitions.py

Line 386 in a14e688

tokens = re.split(r"(\s+)$", body, maxsplit=1)

If you are fine with it, I will merge the PR as it is and fix the parsing myself afterwards.

[nikitych]

I'll rewrite PR to add \n to the body.

There are also a couple of technically errors of missing \n here and here. I spent some time but could not figure out how to exploit the non-excluded empty string. So I could fix them as well, but without adding tests.

[nforro]

I'll rewrite PR to add \n to the body.

Thanks! Would you also add that case to test_parse?

There are also a couple of technically errors of missing \n here and here. I spent some time but could not figure out how to exploit the non-excluded empty string. So I could fix them as well, but without adding tests.

Good point, but I don't think it matters here, empty lines don't have to be excluded because they can't possibly contain a start of a section. But feel free to replace splitlines() with split("\n") (is that the fix you had in mind?).

[softwarefactory-project-zuul]

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0a7d01d5fbfd4657b9fc137779544627

✔️ pre-commit SUCCESS in 2m 12s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 11s
✔️ specfile-tests-pip-deps SUCCESS in 1m 09s

[nforro]

Thanks!

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d0cdcd11874b479c99ce699a72857e9a

✔️ pre-commit SUCCESS in 2m 49s