Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of conditions #405

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fix parsing of conditions #405

merged 2 commits into from
Jul 29, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Jul 29, 2024

After 157a62b conditional expressions are parsed after macro expansion, which means that the actual expression can be empty. Account for that.

Fixes #403.

nforro added 2 commits July 29, 2024 10:17
After 157a62b conditional expressions are parsed after macro expansion,
which means that the actual expression can be empty. Account for that.

Signed-off-by: Nikola Forró <[email protected]>
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/6d68745b26e7447a9651c47c9377c866

✔️ pre-commit SUCCESS in 2m 09s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 09s
✔️ specfile-tests-pip-deps SUCCESS in 1m 10s

@nforro nforro added the mergeit Zuul, merge it! label Jul 29, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/29bbf98c9ae44c8f88f52c82d29dcdff

✔️ pre-commit SUCCESS in 2m 15s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 9930c15 into main Jul 29, 2024
27 of 28 checks passed
@nforro nforro deleted the conditions branch July 29, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Zuul, merge it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to parse NetworkManager.spec
2 participants