Explicitly invalidate the global parse hash in SpecParser constructor
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python can reuse id of objects after they are garbage-collected, however the global parse hash contains an id of `SpecParser` instance in order to force parsing on context switches, and when a different instance has the same id, it has no way to detect that. Explicitly invalidate the global parse hash when a `SpecParser` instance is created to prevent this issue. Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 11s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 09s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python can reuse id of objects after they are garbage-collected, however the global parse hash contains an id of
SpecParserinstance in order to force parsing on context switches, and when a different instance has the same id, it has no way to detect that.Explicitly invalidate the global parse hash when a
SpecParserinstance is created to prevent this issue.Fixes packit/packit-service#2461.